Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Container often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Container, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | abstract class Container implements Datastore_Holder_Interface { |
||
19 | /** |
||
20 | * Where to put a particular tab -- at the head or the tail. Tail by default |
||
21 | */ |
||
22 | const TABS_TAIL = 1; |
||
23 | const TABS_HEAD = 2; |
||
24 | |||
25 | /** |
||
26 | * Separator signifying field hierarchy relation |
||
27 | * Used when searching for fields in a specific complex field |
||
28 | */ |
||
29 | const HIERARCHY_FIELD_SEPARATOR = '/'; |
||
30 | |||
31 | /** |
||
32 | * Separator signifying complex_field->group relation |
||
33 | * Used when searching for fields in a specific complex field group |
||
34 | */ |
||
35 | const HIERARCHY_GROUP_SEPARATOR = ':'; |
||
36 | |||
37 | /** |
||
38 | * Stores if the container is active on the current page |
||
39 | * |
||
40 | * @see activate() |
||
41 | * @var bool |
||
42 | */ |
||
43 | protected $active = false; |
||
44 | |||
45 | /** |
||
46 | * List of registered unique field names for this container instance |
||
47 | * |
||
48 | * @see register_field_name() |
||
49 | * @var array |
||
50 | */ |
||
51 | protected $registered_field_names = array(); |
||
52 | |||
53 | /** |
||
54 | * Tabs available |
||
55 | */ |
||
56 | protected $tabs = array(); |
||
57 | |||
58 | /** |
||
59 | * List of default container settings |
||
60 | * |
||
61 | * @see init() |
||
62 | * @var array |
||
63 | */ |
||
64 | public $settings = array(); |
||
65 | |||
66 | /** |
||
67 | * Title of the container |
||
68 | * |
||
69 | * @var string |
||
70 | */ |
||
71 | public $title = ''; |
||
72 | |||
73 | /** |
||
74 | * List of notification messages to be displayed on the front-end |
||
75 | * |
||
76 | * @var array |
||
77 | */ |
||
78 | protected $notifications = array(); |
||
79 | |||
80 | /** |
||
81 | * List of error messages to be displayed on the front-end |
||
82 | * |
||
83 | * @var array |
||
84 | */ |
||
85 | protected $errors = array(); |
||
86 | |||
87 | /** |
||
88 | * List of container fields |
||
89 | * |
||
90 | * @see add_fields() |
||
91 | * @var array |
||
92 | */ |
||
93 | protected $fields = array(); |
||
94 | |||
95 | /** |
||
96 | * Array of custom CSS classes. |
||
97 | * |
||
98 | * @see set_classes() |
||
99 | * @see get_classes() |
||
100 | * @var array<string> |
||
101 | */ |
||
102 | protected $classes = array(); |
||
103 | |||
104 | /** |
||
105 | * Container datastores. Propagated to all container fields |
||
106 | * |
||
107 | * @see set_datastore() |
||
108 | * @see get_datastore() |
||
109 | * @var object |
||
110 | */ |
||
111 | protected $datastore; |
||
112 | |||
113 | /** |
||
114 | * Flag whether the datastore is the default one or replaced with a custom one |
||
115 | * |
||
116 | * @see set_datastore() |
||
117 | * @see get_datastore() |
||
118 | * @var boolean |
||
119 | */ |
||
120 | protected $has_default_datastore = true; |
||
121 | |||
122 | /** |
||
123 | * Fulfillable_Collection to use when checking attachment/saving conditions |
||
124 | * |
||
125 | * @var Fulfillable_Collection |
||
126 | */ |
||
127 | protected $condition_collection; |
||
128 | |||
129 | /** |
||
130 | * Translator to use when translating conditions to json |
||
131 | * |
||
132 | * @var Carbon_Fields\Container\Fulfillable\Translator\Translator |
||
133 | */ |
||
134 | protected $condition_translator; |
||
135 | |||
136 | /** |
||
137 | * Create a new container of type $type and name $name. |
||
138 | * |
||
139 | * @param string $raw_type |
||
140 | * @param string $id Unique id for the container. Optional |
||
141 | * @param string $name Human-readable name of the container |
||
142 | * @return Container $container |
||
143 | */ |
||
144 | 8 | public static function factory( $raw_type, $id, $name = '' ) { |
|
190 | |||
191 | /** |
||
192 | * An alias of factory(). |
||
193 | * |
||
194 | * @see Container::factory() |
||
195 | * @return Container |
||
196 | */ |
||
197 | public static function make() { |
||
200 | |||
201 | /** |
||
202 | * Create a new container |
||
203 | * |
||
204 | * @param string $id Unique id of the container |
||
205 | * @param string $title Title of the container |
||
206 | * @param string $type Type of the container |
||
207 | * @param Fulfillable_Collection $condition_collection |
||
208 | * @param Carbon_Fields\Container\Fulfillable\Translator\Translator $condition_translator |
||
209 | */ |
||
210 | 2 | public function __construct( $id, $title, $type, $condition_collection, $condition_translator ) { |
|
227 | |||
228 | /** |
||
229 | * Return the container id |
||
230 | * |
||
231 | * @return string |
||
232 | */ |
||
233 | public function get_id() { |
||
236 | |||
237 | /** |
||
238 | * Get array of all static condition types |
||
239 | * |
||
240 | * @param boolean $static |
||
241 | * @return array<string> |
||
242 | */ |
||
243 | protected function get_condition_types( $static ) { |
||
253 | |||
254 | /** |
||
255 | * Return whether the container is active |
||
256 | */ |
||
257 | public function is_active() { |
||
260 | |||
261 | /** |
||
262 | * Activate the container and trigger an action |
||
263 | */ |
||
264 | protected function activate() { |
||
274 | |||
275 | /** |
||
276 | * Perform instance initialization |
||
277 | */ |
||
278 | abstract public function init(); |
||
279 | |||
280 | /** |
||
281 | * Boot the container once it's attached. |
||
282 | */ |
||
283 | protected function boot() { |
||
286 | |||
287 | /** |
||
288 | * Load the value for each field in the container. |
||
289 | * Could be used internally during container rendering |
||
290 | */ |
||
291 | public function load() { |
||
296 | |||
297 | /** |
||
298 | * Called first as part of the container save procedure. |
||
299 | * Responsible for checking the request validity and |
||
300 | * calling the container-specific save() method |
||
301 | * |
||
302 | * @see save() |
||
303 | * @see is_valid_save() |
||
304 | */ |
||
305 | public function _save() { |
||
311 | |||
312 | /** |
||
313 | * Load submitted data and save each field in the container |
||
314 | * |
||
315 | * @see is_valid_save() |
||
316 | */ |
||
317 | public function save( $data = null ) { |
||
323 | |||
324 | /** |
||
325 | * Checks whether the current save request is valid |
||
326 | * |
||
327 | * @return bool |
||
328 | */ |
||
329 | final protected function _is_valid_save() { |
||
334 | |||
335 | /** |
||
336 | * Checks whether the current save request is valid |
||
337 | * |
||
338 | * @return bool |
||
339 | */ |
||
340 | abstract protected function is_valid_save(); |
||
341 | |||
342 | /** |
||
343 | * Called first as part of the container attachment procedure. |
||
344 | * Responsible for checking it's OK to attach the container |
||
345 | * and if it is, calling the container-specific attach() method |
||
346 | * |
||
347 | * @see attach() |
||
348 | * @see is_valid_attach() |
||
349 | */ |
||
350 | public function _attach() { |
||
363 | |||
364 | /** |
||
365 | * Attach the container rendering and helping methods |
||
366 | * to concrete WordPress Action hooks |
||
367 | */ |
||
368 | public function attach() {} |
||
369 | |||
370 | /** |
||
371 | * Perform checks whether the container should be attached during the current request |
||
372 | * |
||
373 | * @return bool True if the container is allowed to be attached |
||
374 | */ |
||
375 | final public function is_valid_attach() { |
||
379 | |||
380 | /** |
||
381 | * Get environment array for page request (in admin) |
||
382 | * |
||
383 | * @return array |
||
384 | */ |
||
385 | abstract protected function get_environment_for_request(); |
||
386 | |||
387 | /** |
||
388 | * Check container attachment rules against current page request (in admin) |
||
389 | * |
||
390 | * @return bool |
||
391 | */ |
||
392 | abstract protected function is_valid_attach_for_request(); |
||
393 | |||
394 | /** |
||
395 | * Check if conditions pass for request |
||
396 | * |
||
397 | * @return bool |
||
398 | */ |
||
399 | protected function static_conditions_pass() { |
||
407 | |||
408 | /** |
||
409 | * Get environment array for object id |
||
410 | * |
||
411 | * @param integer $object_id |
||
412 | * @return array |
||
413 | */ |
||
414 | abstract protected function get_environment_for_object( $object_id ); |
||
415 | |||
416 | /** |
||
417 | * Check container attachment rules against object id |
||
418 | * |
||
419 | * @param int $object_id |
||
420 | * @return bool |
||
421 | */ |
||
422 | abstract public function is_valid_attach_for_object( $object_id ); |
||
423 | |||
424 | /** |
||
425 | * Check if all conditions pass for object |
||
426 | * |
||
427 | * @param integer $object_id |
||
428 | * @return bool |
||
429 | */ |
||
430 | protected function all_conditions_pass( $object_id ) { |
||
434 | |||
435 | /** |
||
436 | * Whether this container is currently viewed. |
||
437 | */ |
||
438 | public function should_activate() { |
||
441 | |||
442 | /** |
||
443 | * Perform a check whether the current container has fields |
||
444 | * |
||
445 | * @return bool |
||
446 | */ |
||
447 | public function has_fields() { |
||
450 | |||
451 | /** |
||
452 | * Returns the private container array of fields. |
||
453 | * Use only if you are completely aware of what you are doing. |
||
454 | * |
||
455 | * @return array |
||
456 | */ |
||
457 | public function get_fields() { |
||
460 | |||
461 | /** |
||
462 | * Return root field from container with specified name |
||
463 | * |
||
464 | * @example crb_complex |
||
465 | * |
||
466 | * @param string $field_name |
||
467 | * @return Field |
||
468 | */ |
||
469 | public function get_root_field_by_name( $field_name ) { |
||
478 | |||
479 | /** |
||
480 | * Get a regex to match field name patterns used to fetch specific fields |
||
481 | * |
||
482 | * @return string |
||
483 | */ |
||
484 | protected function get_field_pattern_regex() { |
||
499 | |||
500 | /** |
||
501 | * Return field from container with specified name |
||
502 | * |
||
503 | * @example $field_name = 'crb_complex/text_field' |
||
504 | * @example $field_name = 'crb_complex/complex_2' |
||
505 | * @example $field_name = 'crb_complex/complex_2:text_group/text_field' |
||
506 | * @example $field_name = 'crb_complex[3]/complex_2[1]:text_group/text_field' |
||
507 | * |
||
508 | * @param string $field_name |
||
509 | * @return Field |
||
510 | */ |
||
511 | public function get_field_by_name( $field_name ) { |
||
557 | |||
558 | /** |
||
559 | * Perform checks whether there is a field registered with the name $name. |
||
560 | * If not, the field name is recorded. |
||
561 | * |
||
562 | * @param string $name |
||
563 | * @return boolean |
||
564 | */ |
||
565 | View Code Duplication | protected function register_field_name( $name ) { |
|
574 | |||
575 | /** |
||
576 | * Return whether the datastore instance is the default one or has been overriden |
||
577 | * |
||
578 | * @return boolean |
||
579 | */ |
||
580 | 6 | public function has_default_datastore() { |
|
583 | |||
584 | /** |
||
585 | * Set datastore instance |
||
586 | * |
||
587 | * @param Datastore_Interface $datastore |
||
588 | * @return Container $this |
||
589 | */ |
||
590 | 6 | View Code Duplication | public function set_datastore( Datastore_Interface $datastore, $set_as_default = false ) { |
602 | |||
603 | /** |
||
604 | * Get the DataStore instance |
||
605 | * |
||
606 | * @return Datastore_Interface $datastore |
||
607 | */ |
||
608 | 6 | public function get_datastore() { |
|
611 | |||
612 | /** |
||
613 | * Return WordPress nonce name used to identify the current container instance |
||
614 | * |
||
615 | * @return string |
||
616 | */ |
||
617 | protected function get_nonce_name() { |
||
620 | |||
621 | /** |
||
622 | * Return WordPress nonce name used to identify the current container instance |
||
623 | * |
||
624 | * @return string |
||
625 | */ |
||
626 | protected function get_nonce_value() { |
||
629 | |||
630 | /** |
||
631 | * Check if the nonce is present in the request and that it is verified |
||
632 | * |
||
633 | * @return bool |
||
634 | */ |
||
635 | protected function verified_nonce_in_request() { |
||
641 | |||
642 | /** |
||
643 | * Internal function that creates the tab and associates it with particular field set |
||
644 | * |
||
645 | * @param string $tab_name |
||
646 | * @param array $fields |
||
647 | * @param int $queue_end |
||
648 | * @return object $this |
||
649 | */ |
||
650 | private function create_tab( $tab_name, $fields, $queue_end = self::TABS_TAIL ) { |
||
671 | |||
672 | /** |
||
673 | * Whether the container is tabbed or not |
||
674 | * |
||
675 | * @return bool |
||
676 | */ |
||
677 | public function is_tabbed() { |
||
680 | |||
681 | /** |
||
682 | * Retrieve all fields that are not defined under a specific tab |
||
683 | * |
||
684 | * @return array |
||
685 | */ |
||
686 | protected function get_untabbed_fields() { |
||
698 | |||
699 | /** |
||
700 | * Retrieve all tabs. |
||
701 | * Create a default tab if there are any untabbed fields. |
||
702 | * |
||
703 | * @return array |
||
704 | */ |
||
705 | protected function get_tabs() { |
||
714 | |||
715 | /** |
||
716 | * Build the tabs JSON |
||
717 | * |
||
718 | * @return array |
||
719 | */ |
||
720 | protected function get_tabs_json() { |
||
732 | |||
733 | /** |
||
734 | * Get custom CSS classes. |
||
735 | * |
||
736 | * @return array<string> |
||
737 | */ |
||
738 | public function get_classes() { |
||
741 | |||
742 | /** |
||
743 | * Set CSS classes that the container should use. |
||
744 | * |
||
745 | * @param string|array<string> $classes |
||
746 | * @return Container $this |
||
747 | */ |
||
748 | public function set_classes( $classes ) { |
||
752 | |||
753 | /** |
||
754 | * Returns an array that holds the container data, suitable for JSON representation. |
||
755 | * |
||
756 | * @param bool $load Should the value be loaded from the database or use the value from the current instance. |
||
757 | * @return array |
||
758 | */ |
||
759 | public function to_json( $load ) { |
||
785 | |||
786 | /** |
||
787 | * COMMON USAGE METHODS |
||
788 | */ |
||
789 | |||
790 | /** |
||
791 | * Append array of fields to the current fields set. All items of the array |
||
792 | * must be instances of Field and their names should be unique for all |
||
793 | * Carbon containers. |
||
794 | * If a field does not have DataStore already, the container datastore is |
||
795 | * assigned to them instead. |
||
796 | * |
||
797 | * @param array $fields |
||
798 | * @return Container $this |
||
799 | */ |
||
800 | public function add_fields( $fields ) { |
||
822 | |||
823 | /** |
||
824 | * Configuration function for adding tab with fields |
||
825 | * |
||
826 | * @param string $tab_name |
||
827 | * @param array $fields |
||
828 | * @return Container $this |
||
829 | */ |
||
830 | public function add_tab( $tab_name, $fields ) { |
||
835 | |||
836 | /** |
||
837 | * Proxy function to set attachment conditions |
||
838 | * |
||
839 | * @see Fulfillable_Collection::where() |
||
840 | * @return Container $this |
||
841 | */ |
||
842 | public function where() { |
||
846 | |||
847 | /** |
||
848 | * Proxy function to set attachment conditions |
||
849 | * |
||
850 | * @see Fulfillable_Collection::or_where() |
||
851 | * @return Container $this |
||
852 | */ |
||
853 | public function or_where() { |
||
857 | } |
||
858 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.