Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Container often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Container, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | abstract class Container implements Datastore_Holder_Interface { |
||
| 19 | /** |
||
| 20 | * Where to put a particular tab -- at the head or the tail. Tail by default |
||
| 21 | */ |
||
| 22 | const TABS_TAIL = 1; |
||
| 23 | const TABS_HEAD = 2; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * Separator signifying field hierarchy relation |
||
| 27 | * Used when searching for fields in a specific complex field |
||
| 28 | */ |
||
| 29 | const HIERARCHY_FIELD_SEPARATOR = '/'; |
||
| 30 | |||
| 31 | /** |
||
| 32 | * Separator signifying complex_field->group relation |
||
| 33 | * Used when searching for fields in a specific complex field group |
||
| 34 | */ |
||
| 35 | const HIERARCHY_GROUP_SEPARATOR = ':'; |
||
| 36 | |||
| 37 | /** |
||
| 38 | * Stores if the container is active on the current page |
||
| 39 | * |
||
| 40 | * @see activate() |
||
| 41 | * @var bool |
||
| 42 | */ |
||
| 43 | protected $active = false; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * List of registered unique field names for this container instance |
||
| 47 | * |
||
| 48 | * @see register_field_name() |
||
| 49 | * @var array |
||
| 50 | */ |
||
| 51 | protected $registered_field_names = array(); |
||
| 52 | |||
| 53 | /** |
||
| 54 | * Tabs available |
||
| 55 | */ |
||
| 56 | protected $tabs = array(); |
||
| 57 | |||
| 58 | /** |
||
| 59 | * List of default container settings |
||
| 60 | * |
||
| 61 | * @see init() |
||
| 62 | * @var array |
||
| 63 | */ |
||
| 64 | public $settings = array(); |
||
| 65 | |||
| 66 | /** |
||
| 67 | * Title of the container |
||
| 68 | * |
||
| 69 | * @var string |
||
| 70 | */ |
||
| 71 | public $title = ''; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * List of notification messages to be displayed on the front-end |
||
| 75 | * |
||
| 76 | * @var array |
||
| 77 | */ |
||
| 78 | protected $notifications = array(); |
||
| 79 | |||
| 80 | /** |
||
| 81 | * List of error messages to be displayed on the front-end |
||
| 82 | * |
||
| 83 | * @var array |
||
| 84 | */ |
||
| 85 | protected $errors = array(); |
||
| 86 | |||
| 87 | /** |
||
| 88 | * List of container fields |
||
| 89 | * |
||
| 90 | * @see add_fields() |
||
| 91 | * @var array |
||
| 92 | */ |
||
| 93 | protected $fields = array(); |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Array of custom CSS classes. |
||
| 97 | * |
||
| 98 | * @see set_classes() |
||
| 99 | * @see get_classes() |
||
| 100 | * @var array<string> |
||
| 101 | */ |
||
| 102 | protected $classes = array(); |
||
| 103 | |||
| 104 | /** |
||
| 105 | * Container datastores. Propagated to all container fields |
||
| 106 | * |
||
| 107 | * @see set_datastore() |
||
| 108 | * @see get_datastore() |
||
| 109 | * @var object |
||
| 110 | */ |
||
| 111 | protected $datastore; |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Flag whether the datastore is the default one or replaced with a custom one |
||
| 115 | * |
||
| 116 | * @see set_datastore() |
||
| 117 | * @see get_datastore() |
||
| 118 | * @var boolean |
||
| 119 | */ |
||
| 120 | protected $has_default_datastore = true; |
||
| 121 | |||
| 122 | /** |
||
| 123 | * Fulfillable_Collection to use when checking attachment/saving conditions |
||
| 124 | * |
||
| 125 | * @var Fulfillable_Collection |
||
| 126 | */ |
||
| 127 | protected $condition_collection; |
||
| 128 | |||
| 129 | /** |
||
| 130 | * Translator to use when translating conditions to json |
||
| 131 | * |
||
| 132 | * @var Carbon_Fields\Container\Fulfillable\Translator\Translator |
||
| 133 | */ |
||
| 134 | protected $condition_translator; |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Create a new container of type $type and name $name. |
||
| 138 | * |
||
| 139 | * @param string $raw_type |
||
| 140 | * @param string $name Human-readable name of the container |
||
| 141 | * @return object $container |
||
| 142 | */ |
||
| 143 | 8 | public static function factory( $raw_type, $name ) { |
|
| 173 | |||
| 174 | /** |
||
| 175 | * An alias of factory(). |
||
| 176 | * |
||
| 177 | * @see Container::factory() |
||
| 178 | */ |
||
| 179 | public static function make( $type, $name ) { |
||
| 182 | |||
| 183 | /** |
||
| 184 | * Create a new container |
||
| 185 | * |
||
| 186 | * @param string $unique_id Unique id of the container |
||
| 187 | * @param string $title title of the container |
||
| 188 | * @param string $type Type of the container |
||
| 189 | * @param Fulfillable_Collection $condition_collection |
||
| 190 | * @param Carbon_Fields\Container\Fulfillable\Translator\Translator $condition_translator |
||
| 191 | */ |
||
| 192 | 2 | public function __construct( $unique_id, $title, $type, $condition_collection, $condition_translator ) { |
|
| 209 | |||
| 210 | /** |
||
| 211 | * Get array of all static condition types |
||
| 212 | * |
||
| 213 | * @param boolean $static |
||
| 214 | * @return array<string> |
||
| 215 | */ |
||
| 216 | protected function get_condition_types( $static ) { |
||
| 226 | |||
| 227 | /** |
||
| 228 | * Return whether the container is active |
||
| 229 | */ |
||
| 230 | public function is_active() { |
||
| 233 | |||
| 234 | /** |
||
| 235 | * Activate the container and trigger an action |
||
| 236 | */ |
||
| 237 | protected function activate() { |
||
| 247 | |||
| 248 | /** |
||
| 249 | * Perform instance initialization |
||
| 250 | */ |
||
| 251 | abstract public function init(); |
||
| 252 | |||
| 253 | /** |
||
| 254 | * Boot the container once it's attached. |
||
| 255 | */ |
||
| 256 | protected function boot() { |
||
| 259 | |||
| 260 | /** |
||
| 261 | * Load the value for each field in the container. |
||
| 262 | * Could be used internally during container rendering |
||
| 263 | */ |
||
| 264 | public function load() { |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Called first as part of the container save procedure. |
||
| 272 | * Responsible for checking the request validity and |
||
| 273 | * calling the container-specific save() method |
||
| 274 | * |
||
| 275 | * @see save() |
||
| 276 | * @see is_valid_save() |
||
| 277 | */ |
||
| 278 | public function _save() { |
||
| 284 | |||
| 285 | /** |
||
| 286 | * Load submitted data and save each field in the container |
||
| 287 | * |
||
| 288 | * @see is_valid_save() |
||
| 289 | */ |
||
| 290 | public function save( $data = null ) { |
||
| 296 | |||
| 297 | /** |
||
| 298 | * Checks whether the current save request is valid |
||
| 299 | * |
||
| 300 | * @return bool |
||
| 301 | */ |
||
| 302 | final protected function _is_valid_save() { |
||
| 307 | |||
| 308 | /** |
||
| 309 | * Checks whether the current save request is valid |
||
| 310 | * |
||
| 311 | * @return bool |
||
| 312 | */ |
||
| 313 | abstract protected function is_valid_save(); |
||
| 314 | |||
| 315 | /** |
||
| 316 | * Called first as part of the container attachment procedure. |
||
| 317 | * Responsible for checking it's OK to attach the container |
||
| 318 | * and if it is, calling the container-specific attach() method |
||
| 319 | * |
||
| 320 | * @see attach() |
||
| 321 | * @see is_valid_attach() |
||
| 322 | */ |
||
| 323 | public function _attach() { |
||
| 336 | |||
| 337 | /** |
||
| 338 | * Attach the container rendering and helping methods |
||
| 339 | * to concrete WordPress Action hooks |
||
| 340 | */ |
||
| 341 | public function attach() {} |
||
| 342 | |||
| 343 | /** |
||
| 344 | * Perform checks whether the container should be attached during the current request |
||
| 345 | * |
||
| 346 | * @return bool True if the container is allowed to be attached |
||
| 347 | */ |
||
| 348 | final public function is_valid_attach() { |
||
| 352 | |||
| 353 | /** |
||
| 354 | * Get environment array for page request (in admin) |
||
| 355 | * |
||
| 356 | * @return array |
||
| 357 | */ |
||
| 358 | abstract protected function get_environment_for_request(); |
||
| 359 | |||
| 360 | /** |
||
| 361 | * Check container attachment rules against current page request (in admin) |
||
| 362 | * |
||
| 363 | * @return bool |
||
| 364 | */ |
||
| 365 | abstract protected function is_valid_attach_for_request(); |
||
| 366 | |||
| 367 | /** |
||
| 368 | * Check if conditions pass for request |
||
| 369 | * |
||
| 370 | * @return bool |
||
| 371 | */ |
||
| 372 | protected function static_conditions_pass() { |
||
| 380 | |||
| 381 | /** |
||
| 382 | * Get environment array for object id |
||
| 383 | * |
||
| 384 | * @param integer $object_id |
||
| 385 | * @return array |
||
| 386 | */ |
||
| 387 | abstract protected function get_environment_for_object( $object_id ); |
||
| 388 | |||
| 389 | /** |
||
| 390 | * Check container attachment rules against object id |
||
| 391 | * |
||
| 392 | * @param int $object_id |
||
| 393 | * @return bool |
||
| 394 | */ |
||
| 395 | abstract public function is_valid_attach_for_object( $object_id ); |
||
| 396 | |||
| 397 | /** |
||
| 398 | * Check if all conditions pass for object |
||
| 399 | * |
||
| 400 | * @return bool |
||
| 401 | */ |
||
| 402 | protected function all_conditions_pass( $object_id ) { |
||
| 406 | |||
| 407 | /** |
||
| 408 | * Whether this container is currently viewed. |
||
| 409 | */ |
||
| 410 | public function should_activate() { |
||
| 413 | |||
| 414 | /** |
||
| 415 | * Perform a check whether the current container has fields |
||
| 416 | * |
||
| 417 | * @return bool |
||
| 418 | */ |
||
| 419 | public function has_fields() { |
||
| 422 | |||
| 423 | /** |
||
| 424 | * Returns the private container array of fields. |
||
| 425 | * Use only if you are completely aware of what you are doing. |
||
| 426 | * |
||
| 427 | * @return array |
||
| 428 | */ |
||
| 429 | public function get_fields() { |
||
| 432 | |||
| 433 | /** |
||
| 434 | * Return root field from container with specified name |
||
| 435 | * |
||
| 436 | * @example crb_complex |
||
| 437 | * |
||
| 438 | * @param string $field_name |
||
| 439 | * @return Field |
||
| 440 | */ |
||
| 441 | public function get_root_field_by_name( $field_name ) { |
||
| 450 | |||
| 451 | /** |
||
| 452 | * Get a regex to match field name patterns used to fetch specific fields |
||
| 453 | * |
||
| 454 | * @return string |
||
| 455 | */ |
||
| 456 | protected function get_field_pattern_regex() { |
||
| 471 | |||
| 472 | /** |
||
| 473 | * Return field from container with specified name |
||
| 474 | * |
||
| 475 | * @example $field_name = 'crb_complex/text_field' |
||
| 476 | * @example $field_name = 'crb_complex/complex_2' |
||
| 477 | * @example $field_name = 'crb_complex/complex_2:text_group/text_field' |
||
| 478 | * @example $field_name = 'crb_complex[3]/complex_2[1]:text_group/text_field' |
||
| 479 | * |
||
| 480 | * @param string $field_name |
||
| 481 | * @return Field |
||
| 482 | */ |
||
| 483 | public function get_field_by_name( $field_name ) { |
||
| 532 | |||
| 533 | /** |
||
| 534 | * Perform checks whether there is a field registered with the name $name. |
||
| 535 | * If not, the field name is recorded. |
||
| 536 | * |
||
| 537 | * @param string $name |
||
| 538 | * @return boolean |
||
| 539 | */ |
||
| 540 | View Code Duplication | protected function register_field_name( $name ) { |
|
| 549 | |||
| 550 | /** |
||
| 551 | * Return whether the datastore instance is the default one or has been overriden |
||
| 552 | * |
||
| 553 | * @return boolean |
||
| 554 | */ |
||
| 555 | 6 | public function has_default_datastore() { |
|
| 558 | |||
| 559 | /** |
||
| 560 | * Set datastore instance |
||
| 561 | * |
||
| 562 | * @param Datastore_Interface $datastore |
||
| 563 | * @return object $this |
||
| 564 | */ |
||
| 565 | 6 | View Code Duplication | public function set_datastore( Datastore_Interface $datastore, $set_as_default = false ) { |
| 577 | |||
| 578 | /** |
||
| 579 | * Get the DataStore instance |
||
| 580 | * |
||
| 581 | * @return Datastore_Interface $datastore |
||
| 582 | */ |
||
| 583 | 6 | public function get_datastore() { |
|
| 586 | |||
| 587 | /** |
||
| 588 | * Return WordPress nonce name used to identify the current container instance |
||
| 589 | * |
||
| 590 | * @return string |
||
| 591 | */ |
||
| 592 | protected function get_nonce_name() { |
||
| 595 | |||
| 596 | /** |
||
| 597 | * Return WordPress nonce name used to identify the current container instance |
||
| 598 | * |
||
| 599 | * @return string |
||
| 600 | */ |
||
| 601 | protected function get_nonce_value() { |
||
| 604 | |||
| 605 | /** |
||
| 606 | * Check if the nonce is present in the request and that it is verified |
||
| 607 | * |
||
| 608 | * @return bool |
||
| 609 | */ |
||
| 610 | protected function verified_nonce_in_request() { |
||
| 616 | |||
| 617 | /** |
||
| 618 | * Internal function that creates the tab and associates it with particular field set |
||
| 619 | * |
||
| 620 | * @param string $tab_name |
||
| 621 | * @param array $fields |
||
| 622 | * @param int $queue_end |
||
| 623 | * @return object $this |
||
| 624 | */ |
||
| 625 | private function create_tab( $tab_name, $fields, $queue_end = self::TABS_TAIL ) { |
||
| 646 | |||
| 647 | /** |
||
| 648 | * Whether the container is tabbed or not |
||
| 649 | * |
||
| 650 | * @return bool |
||
| 651 | */ |
||
| 652 | public function is_tabbed() { |
||
| 655 | |||
| 656 | /** |
||
| 657 | * Retrieve all fields that are not defined under a specific tab |
||
| 658 | * |
||
| 659 | * @return array |
||
| 660 | */ |
||
| 661 | protected function get_untabbed_fields() { |
||
| 673 | |||
| 674 | /** |
||
| 675 | * Retrieve all tabs. |
||
| 676 | * Create a default tab if there are any untabbed fields. |
||
| 677 | * |
||
| 678 | * @return array |
||
| 679 | */ |
||
| 680 | protected function get_tabs() { |
||
| 689 | |||
| 690 | /** |
||
| 691 | * Build the tabs JSON |
||
| 692 | * |
||
| 693 | * @return array |
||
| 694 | */ |
||
| 695 | protected function get_tabs_json() { |
||
| 707 | |||
| 708 | /** |
||
| 709 | * Get custom CSS classes. |
||
| 710 | * |
||
| 711 | * @return array<string> |
||
| 712 | */ |
||
| 713 | public function get_classes() { |
||
| 716 | |||
| 717 | /** |
||
| 718 | * Set CSS classes that the container should use. |
||
| 719 | * |
||
| 720 | * @param string|array<string> $classes |
||
| 721 | * @return object $this |
||
| 722 | */ |
||
| 723 | public function set_classes( $classes ) { |
||
| 727 | |||
| 728 | /** |
||
| 729 | * Returns an array that holds the container data, suitable for JSON representation. |
||
| 730 | * |
||
| 731 | * @param bool $load Should the value be loaded from the database or use the value from the current instance. |
||
| 732 | * @return array |
||
| 733 | */ |
||
| 734 | public function to_json( $load ) { |
||
| 760 | |||
| 761 | /** |
||
| 762 | * Enqueue admin styles |
||
| 763 | */ |
||
| 764 | public static function admin_hook_styles() { |
||
| 767 | |||
| 768 | /** |
||
| 769 | * COMMON USAGE METHODS |
||
| 770 | */ |
||
| 771 | |||
| 772 | /** |
||
| 773 | * Append array of fields to the current fields set. All items of the array |
||
| 774 | * must be instances of Field and their names should be unique for all |
||
| 775 | * Carbon containers. |
||
| 776 | * If a field does not have DataStore already, the container datastore is |
||
| 777 | * assigned to them instead. |
||
| 778 | * |
||
| 779 | * @param array $fields |
||
| 780 | * @return object $this |
||
| 781 | */ |
||
| 782 | public function add_fields( $fields ) { |
||
| 804 | |||
| 805 | /** |
||
| 806 | * Configuration function for adding tab with fields |
||
| 807 | * |
||
| 808 | * @param string $tab_name |
||
| 809 | * @param array $fields |
||
| 810 | * @return object $this |
||
| 811 | */ |
||
| 812 | public function add_tab( $tab_name, $fields ) { |
||
| 817 | |||
| 818 | /** |
||
| 819 | * Proxy function to set attachment conditions |
||
| 820 | * |
||
| 821 | * @see Fulfillable_Collection::where() |
||
| 822 | * @return Container $this |
||
| 823 | */ |
||
| 824 | public function where() { |
||
| 828 | |||
| 829 | /** |
||
| 830 | * Proxy function to set attachment conditions |
||
| 831 | * |
||
| 832 | * @see Fulfillable_Collection::or_where() |
||
| 833 | * @return Container $this |
||
| 834 | */ |
||
| 835 | public function or_where() { |
||
| 839 | } |
||
| 840 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.