Carbon_Fields\Container\Comment_Meta_Container

Complexity

Total Complexity

22

Size/Duplication

Total Lines	139
Duplicated Lines	7.91 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes	8
Bugs	1	Features	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	render()	0	3	1
A	__construct()	0	7	2
A	attach()	0	10	1
A	detach()	11	11	2
A	set_comment_id()	0	4	1
A	save()	0	12	2
A	verify_unique_field_name()	0	11	3
A	drop_unique_field_name()	0	6	2
A	init()	0	8	3
B	is_valid_save()	0	9	5

<?php

namespace Carbon_Fields\Container;

use Carbon_Fields\Datastore\Comment_Meta_Datastore;
use Carbon_Fields\Exception\Incorrect_Syntax_Exception;

/**
 * Comment meta container class. 
 */
class Comment_Meta_Container extends Container {
	protected $comment_id;

	/**
	 * Create a new comment meta container
	 *
	 * @param string $title Unique title of the container
	 **/
	public function __construct( $title ) {
		parent::__construct( $title );

		if ( ! $this->get_datastore() ) {
			$this->set_datastore( new Comment_Meta_Datastore() );
		}
	}

	/**
	 * Perform instance initialization after calling setup()
	 **/
	public function init() {
		if ( isset( $_GET['c'] ) && $comment_id = absint( $_GET['c'] ) ) { // Input var okay.
			$this->set_comment_id( $comment_id );
		}

		add_action( 'admin_init', array( $this, '_attach' ) );
		add_action( 'edit_comment', array( $this, '_save' ) );
	}

	/**
	 * Checks whether the current request is valid
	 *
	 * @return bool
	 **/
	public function is_valid_save() {
		if ( defined( 'DOING_AUTOSAVE' ) && DOING_AUTOSAVE ) {
			return false;
		} else if ( ! isset( $_REQUEST[ $this->get_nonce_name() ] ) || ! wp_verify_nonce( $_REQUEST[ $this->get_nonce_name() ], $this->get_nonce_name() ) ) {

Detected access of super global var $_REQUEST, probably need manual inspection.

Detected usage of a non-sanitized input variable: $_REQUEST

			return false;
		} 

		return true;
	}

	/**
	 * Add meta box to the comment
	 **/
	public function attach() {
		add_meta_box(
			$this->id, 
			$this->title, 
			array( $this, 'render' ), 
			'comment', 
			'normal',
			'high'
		);
	}
	
	/**
	 * Revert the result of attach()
	 **/
	public function detach() {

This method seems to be duplicated in your project.

		parent::detach();

		remove_action( 'admin_init', array( $this, '_attach' ) );
		remove_action( 'edit_comment', array( $this, '_save' ) );

		// unregister field names
		foreach ( $this->fields as $field ) {
			$this->drop_unique_field_name( $field->get_name() );
		}
	}

	/**
	 * Output the container markup
	 **/
	public function render() {
		include \Carbon_Fields\DIR . '/templates/Container/comment_meta.php';
	}

	/**
	 * Set the comment ID the container will operate with.
	 *
	 * @param int $comment_id
	 **/
	public function set_comment_id( $comment_id ) {
		$this->comment_id = $comment_id;
		$this->store->set_id( $comment_id );
	}

	/**
	 * Perform save operation after successful is_valid_save() check.
	 * The call is propagated to all fields in the container.
	 *
	 * @param int $comment_id ID of the comment against which save() is ran
	 **/
	public function save( $comment_id ) {

		// Unhook action to guarantee single save
		remove_action( 'edit_comment', array( $this, '_save' ) );

		$this->set_comment_id( $comment_id );

		foreach ( $this->fields as $field ) {
			$field->set_value_from_input();
			$field->save();
		}
	}

	/**
	 * Perform checks whether there is a field registered with the name $name.
	 * If not, the field name is recorded.
	 *
	 * @param string $name
	 **/
	public function verify_unique_field_name( $name ) {
		if ( ! isset( self::$registered_field_names['comment'] ) ) {
			self::$registered_field_names['comment'] = array();
		}

		if ( in_array( $name, self::$registered_field_names['comment'] ) ) {
			throw new Incorrect_Syntax_Exception( 'Field name "' . $name . '" already registered' );
		}

		self::$registered_field_names['comment'][] = $name;
	}

	/**
	 * Remove field name $name from the list of unique field names
	 *
	 * @param string $name
	 **/
	public function drop_unique_field_name( $name ) {		
		$index = array_search( $name, self::$registered_field_names['comment'] );
		if ( $index !== false ) {

Found "!== false". Use Yoda Condition checks, you must

			unset( self::$registered_field_names['comment'][ $index ] );
		}
	}

}