Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | abstract class Predefined_Options_Field extends Field { |
||
12 | /** |
||
13 | * Stores the raw, unprocessed field options |
||
14 | * |
||
15 | * @var array(array|callable) |
||
16 | **/ |
||
17 | protected $option_collections = array(); |
||
18 | |||
19 | protected function is_indexed_array( $array ) { |
||
20 | return array_keys( $array ) === range( 0, count( $array ) - 1 ); |
||
21 | } |
||
22 | |||
23 | /** |
||
24 | * Set the options of this field. |
||
25 | * Accepts either array of data or a callback that returns the data. |
||
26 | * |
||
27 | * @param array|callable $options |
||
28 | */ |
||
29 | 9 | View Code Duplication | public function set_options( $options ) { |
37 | |||
38 | /** |
||
39 | * Add new options to this field. |
||
40 | * Accepts either array of data or a callback that returns the data. |
||
41 | * |
||
42 | * @param array|callable $options |
||
43 | */ |
||
44 | 13 | View Code Duplication | public function add_options( $options ) { |
52 | |||
53 | /** |
||
54 | * Check if there are callbacks and populate the options |
||
55 | */ |
||
56 | protected function load_options() { |
||
57 | $options = array(); |
||
58 | foreach ( $this->option_collections as $collection ) { |
||
59 | $collection_items = array(); |
||
60 | if ( is_callable( $collection ) ) { |
||
61 | $collection_items = call_user_func( $collection ); |
||
62 | if ( !is_array( $collection_items ) ) { |
||
63 | continue; |
||
64 | } |
||
65 | } else { |
||
66 | foreach ( $collection as $key => $value ) { |
||
67 | if ( is_array( $value ) ) { |
||
68 | $collection_items = $collection_items + $value; |
||
69 | } else { |
||
70 | $collection_items[ $key ] = $value; |
||
71 | } |
||
72 | } |
||
73 | } |
||
74 | if ( $this->is_indexed_array( $options ) && $this->is_indexed_array( $collection_items ) ) { |
||
75 | $options = array_merge( $options, $collection_items ); |
||
76 | } else { |
||
77 | $options = array_replace( $options, $collection_items ); |
||
78 | } |
||
79 | } |
||
80 | |||
81 | return $options; |
||
82 | } |
||
83 | |||
84 | /** |
||
85 | * Retrieve the current options. |
||
86 | * |
||
87 | * @return array|callable $options |
||
88 | */ |
||
89 | 13 | public function get_options() { |
|
92 | |||
93 | /** |
||
94 | * Changes the options array structure. This is needed to keep the array items order when it is JSON encoded. |
||
95 | * Will also work with a callable that returns an array. |
||
96 | * |
||
97 | * @param array|callable $options |
||
98 | * @return array |
||
99 | */ |
||
100 | public function parse_options( $options ) { |
||
116 | } // END Field |
||
117 |