Factory::get_class() - Code Metrics - Inspection of "fix support for custom condition classes" - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — milestone/2_0/react-ui ( d404a3...73b2ee )

unknown

created 2017-04-21 12:56 UTC

Factory::get_class() A

↳ Parent: Factory::make()

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10

<?php

namespace Carbon_Fields\Container\Condition;

use Carbon_Fields\App;
use Carbon_Fields\Helper\Helper;
use Carbon_Fields\Exception\Incorrect_Syntax_Exception;

class Factory {

	/**
	 * Get the type for the specified class
	 * 
	 * @param  string $class
	 * @return string
	 */
	public function get_type( $class ) {
		return Helper::class_to_type( $class, '_Condition' );
	}

	/**
	 * Get an instance of the specified type
	 * 
	 * @param  string $type
	 * @return mixed
	 */
	public function make( $type ) {
		$condition_type_superclass = 'Carbon_Fields\\Container\\Condition\\Condition';

		$normalized_type = Helper::normalize_type( $type );
		
		$identifier = 'container_condition_type_' . $normalized_type;
		if ( App::has( $identifier ) ) {
			return App::resolve( $identifier );
		}

		if ( class_exists( $type ) ) {
			$reflection = new \ReflectionClass( $type );
			if ( $reflection->isSubclassOf( $condition_type_superclass ) ) {
				return new $type();
			} else {
				Incorrect_Syntax_Exception::raise( 'Field must be of type Carbon_Fields\\Field\\Field' );
			}
		}

		Incorrect_Syntax_Exception::raise( 'Unknown condition type "' . $type . '".' );
		return null;
	}
}

1			<?php
2
3			namespace Carbon_Fields\Container\Condition;
4
5			use Carbon_Fields\App;
6			use Carbon_Fields\Helper\Helper;
7			use Carbon_Fields\Exception\Incorrect_Syntax_Exception;
8
9			class Factory {
10
11			/**
12			* Get the type for the specified class
13			*
14			* @param string $class
15			* @return string
16			*/
17			public function get_type( $class ) {
18			return Helper::class_to_type( $class, '_Condition' );
19			}
20
21			/**
22			* Get an instance of the specified type
23			*
24			* @param string $type
25			* @return mixed
26			*/
27			public function make( $type ) {
28			$condition_type_superclass = 'Carbon_Fields\\Container\\Condition\\Condition';
			1 ignored issue – show Comprehensibility Naming introduced 2017-04-21 13:17 UTC by Report Bug Copy Issue Report The variable name `$condition_type_superclass` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
29			$normalized_type = Helper::normalize_type( $type );
30
31			$identifier = 'container_condition_type_' . $normalized_type;
32			if ( App::has( $identifier ) ) {
33			return App::resolve( $identifier );
34			}
35
36			if ( class_exists( $type ) ) {
37			$reflection = new \ReflectionClass( $type );
38			if ( $reflection->isSubclassOf( $condition_type_superclass ) ) {
39			return new $type();
40			} else {
41			Incorrect_Syntax_Exception::raise( 'Field must be of type Carbon_Fields\\Field\\Field' );
42			}
43			}
44
45			Incorrect_Syntax_Exception::raise( 'Unknown condition type "' . $type . '".' );
46			return null;
47			}
48			}

htmlburger / carbon-fields

Push — milestone/2_0/react-ui ( d404a3...73b2ee )

Factory::get_class() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like