Nav_Menu_Edit_Walker::start_el() - Code Metrics - Inspection of "WordPress 4.7 Compatibility update" - htmlburger/carbon-fields - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#151)

unknown

created 2016-12-08 14:32 UTC

Nav_Menu_Edit_Walker::start_el() B

↳ Parent: Nav_Menu_Edit_Walker

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	1
eloc	15
nc	1
nop	5
dl	0
loc	29
rs	8.8571
c	4
b	0
f	0

<?php

namespace Carbon_Fields\Walker;

/**
 * Walker for the administration nav menu editing.
 *
 * @uses Walker_Nav_Menu_Edit
 */
class Nav_Menu_Edit_Walker extends \Walker_Nav_Menu_Edit {

	/**
	 * Start the element output.
	 *
	 * @param string $output Passed by reference. Used to append additional content.
	 * @param object $item   Menu item data object.
	 * @param int    $depth  Depth of menu item. Used for padding.
	 * @param array  $args   An array of arguments. @see wp_nav_menu()
	 * @param int    $id     Current item ID.
	 */
	public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
		parent::start_el( $output, $item, $depth, $args, $id );

		$flag = '<!--CarbonFields-->';

		// Generates the HTML
		ob_start();
		do_action( 'crb_print_carbon_container_nav_menu_fields_html', $item, $output, $depth, $args, $id );
		echo $flag;

		$fields = ob_get_clean();

		// List of possible insertion markers, this may vary between WP Core versions
		$markers = array(
			# WordPress < 4.7
			preg_quote( '<p class="field-move hide-if-no-js description description-wide">' ),
			# WordPress 4.7
			preg_quote( '<fieldset class="field-move hide-if-no-js description description-wide">' ),
		);

		// Build the regex
		$regex = sprintf(
			'~(?<!%s)(%s)~',
			preg_quote( $flag, '~' ),
			implode( '|', $markers)

		);

		// Injects the HTML
		$output = preg_replace( $regex, $fields . "$1", $output );
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

}


1			<?php
2
3			namespace Carbon_Fields\Walker;
4
5			/**
6			* Walker for the administration nav menu editing.
7			*
8			* @uses Walker_Nav_Menu_Edit
9			*/
10			class Nav_Menu_Edit_Walker extends \Walker_Nav_Menu_Edit {
11
12			/**
13			* Start the element output.
14			*
15			* @param string $output Passed by reference. Used to append additional content.
16			* @param object $item Menu item data object.
17			* @param int $depth Depth of menu item. Used for padding.
18			* @param array $args An array of arguments. @see wp_nav_menu()
19			* @param int $id Current item ID.
20			*/
21			public function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
22			parent::start_el( $output, $item, $depth, $args, $id );
23
24			$flag = '<!--CarbonFields-->';
25
26			// Generates the HTML
27			ob_start();
28			do_action( 'crb_print_carbon_container_nav_menu_fields_html', $item, $output, $depth, $args, $id );
29			echo $flag;
			1 ignored issue – show introduced 2016-03-10 09:29 UTC by Report Bug Copy Issue Report Expected next thing to be a escaping function, not '$flag' Loading history...
30			$fields = ob_get_clean();
31
32			// List of possible insertion markers, this may vary between WP Core versions
33			$markers = array(
34			# WordPress < 4.7
35			preg_quote( '<p class="field-move hide-if-no-js description description-wide">' ),
36			# WordPress 4.7
37			preg_quote( '<fieldset class="field-move hide-if-no-js description description-wide">' ),
38			);
39
40			// Build the regex
41			$regex = sprintf(
42			'~(?<!%s)(%s)~',
43			preg_quote( $flag, '~' ),
44			implode( '\|', $markers)
			0 ignored issues – show Coding Style introduced 2016-12-08 14:27 UTC by Report Bug Copy Issue Report Expected 1 spaces before closing bracket; 0 found Loading history...
45			);
46
47			// Injects the HTML
48			$output = preg_replace( $regex, $fields . "$1", $output );
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-08 14:27 UTC by Report Bug Copy Issue Report The string literal `$1` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
49			}
50
51			}
52

htmlburger / carbon-fields

Pull Request — master (#151)

Nav_Menu_Edit_Walker::start_el() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like