Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | View Code Duplication | class Multiselect_Field extends Predefined_Options_Field { |
|
|
|||
9 | /** |
||
10 | * Returns an array that holds the field data, suitable for JSON representation. |
||
11 | * This data will be available in the Underscore template and the Backbone Model. |
||
12 | * |
||
13 | * @param bool $load Should the value be loaded from the database or use the value from the current instance. |
||
14 | * @return array |
||
15 | */ |
||
16 | public function to_json( $load ) { |
||
25 | |||
26 | /** |
||
27 | * The main Underscore template of this field. |
||
28 | */ |
||
29 | public function template() { |
||
44 | } |
||
45 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.