Carbon_Fields\Field\Number_Field

Complexity

Total Complexity

16

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	4
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	template()	0	5	1
A	to_json()	0	11	4
C	save()	0	30	8
A	set_max()	0	5	1
A	set_min()	0	5	1
A	set_step()	0	5	1

<?php

namespace Carbon_Fields\Field;

/**
 * Number field class.
 */
class Number_Field extends Field {

	protected $default_min = 1;
	protected $default_max = 2147483647;
	protected $default_step = 1;

	protected $min = 1;
	protected $max = 2147483647;
	protected $step = 1;

	/**
	 * Underscore template of this field.
	 */
	function template() {

It is generally recommended to explicitly declare the visibility for methods.

		?>
		<input id="{{{ id }}}" type="number" name="{{{ name }}}" value="{{ value }}" max="{{ max }}" min="{{ min }}" step="{{ step }}" pattern="[0-9]*" class="regular-text" />
		<?php
	}

	function to_json( $load ) {

It is generally recommended to explicitly declare the visibility for methods.

		$field_data = parent::to_json( $load );

		$field_data = array_merge( $field_data, array(
			'min' => is_numeric( $this->min ) ? $this->min : $this->default_min,
			'max' => is_numeric( $this->max ) ? $this->max : $this->default_max,
			'step' => is_numeric( $this->step ) ? $this->step : $this->default_step,
		) );

		return $field_data;
	}

	function save() {

It is generally recommended to explicitly declare the visibility for methods.

		$name = $this->get_name();
		$value = $this->get_value();
		$min = $this->min;
		$max = $this->max;
		$step = $this->step;

		// Set the value for the field
		$this->set_name( $name );

		$field_value = '';
		if ( isset( $value ) && $value !== '' && is_numeric( $value ) ) {
			$value = floatval( $value );

			$is_valid_min = $min <= $value;
			$is_valid_max = $value <= $max;

			// Base Formula "value = min + n * step" where "n" should be integer
			$test_for_step_validation = ( $value - $min ) / $step;
			$is_valid_step = $test_for_step_validation === floor( $test_for_step_validation );

			if ( $value !== '' && $is_valid_min && $is_valid_max && $is_valid_step ) {

The strict comparison !== seems to always evaluate to true as the types of $value (double) and '' (string) can never be identical. Maybe you want to use a loose comparison != instead?

				$field_value = $value;
			}
		}

		$this->set_value( $field_value );

		parent::save();
	}

	function set_max( $max ) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->max = $max;

		return $this;
	}

	function set_min( $min ) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->min = $min;

		return $this;
	}

	function set_step( $step ) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->step = $step;

		return $this;
	}
}