Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Scalar_Comparer extends Comparer { |
||
8 | |||
9 | /** |
||
10 | * Supported comparison signs |
||
11 | * |
||
12 | * @var array<string> |
||
13 | */ |
||
14 | protected $supported_comparison_operators = array( '>', '>=', '<', '<=' ); |
||
15 | |||
16 | /** |
||
17 | * Check if comparison is true for $a and $b |
||
18 | * |
||
19 | * @param mixed $a |
||
20 | * @param string $comparison_operator |
||
21 | * @param mixed $b |
||
22 | * @return bool |
||
23 | */ |
||
24 | public function is_correct( $a, $comparison_operator, $b ) { |
||
47 | } |