Issues in MoveJsToFooterTest.php - Fixed Issues - Inspection of "Update dependency" - hryvinskyi/magento2-deferjs - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 512691...36e16a )

by Володимир

created 2019-03-24 12:23 UTC

Test/Unit/Model/MoveJsToFooterTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php
/**
 * Copyright (c) 2019. Volodymyr Hryvinskyi.  All rights reserved.
 * @author: <mailto:[email protected]>
 * @github: <https://github.com/hryvinskyi>
 */

declare(strict_types=1);

namespace Hryvinskyi\DeferJs\Test\Unit\Model;

use Hryvinskyi\DeferJs\Helper\Config;
use Hryvinskyi\DeferJs\Model\Minify\MinifyJsInterface;
use Hryvinskyi\DeferJs\Model\MoveJsToFooter;
use Hryvinskyi\DeferJs\Model\PassesValidator\ValidateSkipper;
use Magento\Framework\App\Response\Http;
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
use PHPUnit\Framework\TestCase;
filter:
    dependency_paths: ["lib/*"]

class MoveJsToFooterTest extends TestCase
{

    /**
     * @var Config|\PHPUnit_Framework_MockObject_MockObject
     */
    private $config;

    /**
     * @var MinifyJsInterface|\PHPUnit_Framework_MockObject_MockObject
     */
    private $minifyJs;

    /**
     * @var ValidateSkipper|\PHPUnit_Framework_MockObject_MockObject
     */
    private $validateSkipper;

    /**
     * @var Http
     */
    private $http;

    /**
     * @var MoveJsToFooter
     */
    private $model;

    /**
     * Sets up the fixture
     *
     * @return void
     */
    protected function setUp()
    {
        $this->config = $this->createPartialMock(
            Config::class,
            ['isMinifyBodyScript']
        );

        $this->minifyJs = $this->createPartialMock(
            MinifyJsInterface::class,
            ['execute']
        );

        $this->validateSkipper = $this->createPartialMock(
            ValidateSkipper::class,
            ['execute']
        );

        $this->http = (new ObjectManager($this))->getObject(Http::class);
        $this->model = (new ObjectManager($this))->getObject(MoveJsToFooter::class, [
            'config' => $this->config,
            'minifyJs' => $this->minifyJs,
            'validateSkipper' => $this->validateSkipper,
        ]);
    }

    public function testExecute(): void
    {
        $beforeBody = '<!DOCTYPE html>' .
            '<html>' .
                '<head>' .
                    '<script> <!-- ko i18n: \'test\' --> <!-- /ko --> </script>' .
                '</head>' .
            '<body>' .
                '<h1>My First Heading</h1>' .
                '<p>My first paragraph.</p>' .
            '</body>' .
        '</html>';

        $afterBody = '<!DOCTYPE html>' .
            '<html>' .
                '<head></head>' .
            '<body>' .
                '<h1>My First Heading</h1>' .
                '<p>My first paragraph.</p>' .
                '<script> <!-- ko i18n: \'test\' --> <!-- /ko --> </script>' .
            '</body>' .
        '</html>';
        $this->http->setBody($beforeBody);
        $this->model->execute($this->http);


        $this->assertEquals($this->http->getBody(), $afterBody);
    }
}


1			<?php
2			/**
3			* Copyright (c) 2019. Volodymyr Hryvinskyi. All rights reserved.
4			* @author: <mailto:[email protected]>
5			* @github: <https://github.com/hryvinskyi>
6			*/
7
8			declare(strict_types=1);
9
10			namespace Hryvinskyi\DeferJs\Test\Unit\Model;
11
12			use Hryvinskyi\DeferJs\Helper\Config;
13			use Hryvinskyi\DeferJs\Model\Minify\MinifyJsInterface;
14			use Hryvinskyi\DeferJs\Model\MoveJsToFooter;
15			use Hryvinskyi\DeferJs\Model\PassesValidator\ValidateSkipper;
16			use Magento\Framework\App\Response\Http;
17			use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
18			use PHPUnit\Framework\TestCase;
			0 ignored issues – show Bug introduced 2019-03-24 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `PHPUnit\Framework\TestCase` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
19
20			class MoveJsToFooterTest extends TestCase
21			{
22
23			/**
24			* @var Config\|\PHPUnit_Framework_MockObject_MockObject
25			*/
26			private $config;
27
28			/**
29			* @var MinifyJsInterface\|\PHPUnit_Framework_MockObject_MockObject
30			*/
31			private $minifyJs;
32
33			/**
34			* @var ValidateSkipper\|\PHPUnit_Framework_MockObject_MockObject
35			*/
36			private $validateSkipper;
37
38			/**
39			* @var Http
40			*/
41			private $http;
42
43			/**
44			* @var MoveJsToFooter
45			*/
46			private $model;
47
48			/**
49			* Sets up the fixture
50			*
51			* @return void
52			*/
53			protected function setUp()
54			{
55			$this->config = $this->createPartialMock(
56			Config::class,
57			['isMinifyBodyScript']
58			);
59
60			$this->minifyJs = $this->createPartialMock(
61			MinifyJsInterface::class,
62			['execute']
63			);
64
65			$this->validateSkipper = $this->createPartialMock(
66			ValidateSkipper::class,
67			['execute']
68			);
69
70			$this->http = (new ObjectManager($this))->getObject(Http::class);
71			$this->model = (new ObjectManager($this))->getObject(MoveJsToFooter::class, [
72			'config' => $this->config,
73			'minifyJs' => $this->minifyJs,
74			'validateSkipper' => $this->validateSkipper,
75			]);
76			}
77
78			public function testExecute(): void
79			{
80			$beforeBody = '<!DOCTYPE html>' .
81			'<html>' .
82			'<head>' .
83			'<script> <!-- ko i18n: \'test\' --> <!-- /ko --> </script>' .
84			'</head>' .
85			'<body>' .
86			'<h1>My First Heading</h1>' .
87			'<p>My first paragraph.</p>' .
88			'</body>' .
89			'</html>';
90
91			$afterBody = '<!DOCTYPE html>' .
92			'<html>' .
93			'<head></head>' .
94			'<body>' .
95			'<h1>My First Heading</h1>' .
96			'<p>My first paragraph.</p>' .
97			'<script> <!-- ko i18n: \'test\' --> <!-- /ko --> </script>' .
98			'</body>' .
99			'</html>';
100			$this->http->setBody($beforeBody);
101			$this->model->execute($this->http);
102
103
104			$this->assertEquals($this->http->getBody(), $afterBody);
105			}
106			}
107

hryvinskyi / magento2-deferjs

Push — master ( 512691...36e16a )

Test/Unit/Model/MoveJsToFooterTest.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like