WatermarkTest - Code Metrics - Inspection of "Update outdate libraries" - hrevert/HtImgModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

unknown

created 2018-04-27 18:34 UTC

WatermarkTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	32
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	testFilter()	11	1
A	testGetExceptionWithInvalidPosition()	9	1
A	testGetExceptionWithInvalidWatermarkSize()	7	1

<?php
namespace HtImgModuleTest\Imagine\Filter;

use Imagine\Gd\Imagine;
use HtImgModule\Imagine\Filter\Watermark;

class WatermarkTest extends \PHPUnit_Framework_TestCase
{
    public function testFilter()
    {
       $imagine = new Imagine();
       $flowers = $imagine->open('resources/flowers.jpg');
       $archos = $imagine->open('resources/Archos.jpg');
       $watermark = new Watermark($archos, '50%');
       $newImage = $watermark->apply($flowers);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
       $watermark = new Watermark($archos, '50%', 'right');
       $newImage = $watermark->apply($flowers);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
       //$newImage->save('resources/watermark.jpg');

    }

   public function testGetExceptionWithInvalidPosition()
   {
       $this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');

       $imagine = new Imagine();
       $archos = $imagine->open('resources/Archos.jpg');
       $flowers = $imagine->open('resources/flowers.jpg');
       $watermark = new Watermark($archos, null, 'asdf');
       $newImage = $watermark->apply($flowers);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
   }

   public function testGetExceptionWithInvalidWatermarkSize()
   {
       $this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');

       $imagine = new Imagine();
       $archos = $imagine->open('resources/Archos.jpg');
       $watermark = new Watermark($archos, 'asfd', 'asdf');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
   }
}


1			<?php
2			namespace HtImgModuleTest\Imagine\Filter;
3
4			use Imagine\Gd\Imagine;
5			use HtImgModule\Imagine\Filter\Watermark;
6
7			class WatermarkTest extends \PHPUnit_Framework_TestCase
8			{
9			public function testFilter()
10			{
11			$imagine = new Imagine();
12			$flowers = $imagine->open('resources/flowers.jpg');
13			$archos = $imagine->open('resources/Archos.jpg');
14			$watermark = new Watermark($archos, '50%');
15			$newImage = $watermark->apply($flowers);
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$newImage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
16			$watermark = new Watermark($archos, '50%', 'right');
17			$newImage = $watermark->apply($flowers);
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$newImage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
18			//$newImage->save('resources/watermark.jpg');
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `86%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19			}
20
21			public function testGetExceptionWithInvalidPosition()
22			{
23			$this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');
			0 ignored issues – show Deprecated Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
24			$imagine = new Imagine();
25			$archos = $imagine->open('resources/Archos.jpg');
26			$flowers = $imagine->open('resources/flowers.jpg');
27			$watermark = new Watermark($archos, null, 'asdf');
28			$newImage = $watermark->apply($flowers);
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$newImage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29			}
30
31			public function testGetExceptionWithInvalidWatermarkSize()
32			{
33			$this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');
			0 ignored issues – show Deprecated Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
34			$imagine = new Imagine();
35			$archos = $imagine->open('resources/Archos.jpg');
36			$watermark = new Watermark($archos, 'asfd', 'asdf');
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$watermark` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37			}
38			}
39

hrevert / HtImgModule

GitHub Access Token became invalid

Pull Request — master (#34)

WatermarkTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like