ChainTest - Code Metrics - Inspection of "Update outdate libraries" - hrevert/HtImgModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

unknown

created 2018-04-27 18:34 UTC

ChainTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	3
lcom	1
cbo	5
dl	0
loc	31
rs	10
c	2
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	testLoad()	12	1
A	testGetExceptionWithNoFilter()	7	1
A	testGetExceptionWithInvalidOptionsType()	7	1

<?php

namespace HtImgModuleTest\Imagine\Filter\Loader;

use HtImgModule\Imagine\Filter\Loader\Chain;
use Zend\ServiceManager\ServiceManager;

class ChainTest extends \PHPUnit_Framework_TestCase
{
    public function testLoad()
    {
        $filterLoaders = new ServiceManager;
        $filterLoader = $this->createMock('HtImgModule\Imagine\Filter\Loader\LoaderInterface');
        $filterLoader->expects($this->any())
            ->method('load')
            ->will($this->returnValue($this->createMock('Imagine\Filter\FilterInterface')));
        $filterLoaders->setService('thumbnail', $filterLoader);
        $chainLoader = new  Chain($filterLoaders);
        $chainFilter = $chainLoader->load(['filters' => ['thumbnail' => ['options' => []]]]);
        $this->assertInstanceOf('HtImgModule\Imagine\Filter\Chain', $chainFilter);
    }

    public function testGetExceptionWithNoFilter()
    {
        $filterLoaders = new ServiceManager;
        $chainLoader = new  Chain($filterLoaders);
        $this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');

        $chainFilter = $chainLoader->load(['filters' => []]);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testGetExceptionWithInvalidOptionsType()
    {
        $filterLoaders = new ServiceManager;
        $chainLoader = new  Chain($filterLoaders);
        $this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');

        $chainFilter = $chainLoader->load(['filters' => '']);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }
}


1			<?php
2
3			namespace HtImgModuleTest\Imagine\Filter\Loader;
4
5			use HtImgModule\Imagine\Filter\Loader\Chain;
6			use Zend\ServiceManager\ServiceManager;
7
8			class ChainTest extends \PHPUnit_Framework_TestCase
9			{
10			public function testLoad()
11			{
12			$filterLoaders = new ServiceManager;
13			$filterLoader = $this->createMock('HtImgModule\Imagine\Filter\Loader\LoaderInterface');
14			$filterLoader->expects($this->any())
15			->method('load')
16			->will($this->returnValue($this->createMock('Imagine\Filter\FilterInterface')));
17			$filterLoaders->setService('thumbnail', $filterLoader);
18			$chainLoader = new Chain($filterLoaders);
19			$chainFilter = $chainLoader->load(['filters' => ['thumbnail' => ['options' => []]]]);
20			$this->assertInstanceOf('HtImgModule\Imagine\Filter\Chain', $chainFilter);
21			}
22
23			public function testGetExceptionWithNoFilter()
24			{
25			$filterLoaders = new ServiceManager;
26			$chainLoader = new Chain($filterLoaders);
27			$this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');
			0 ignored issues – show Deprecated Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
28			$chainFilter = $chainLoader->load(['filters' => []]);
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$chainFilter` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29			}
30
31			public function testGetExceptionWithInvalidOptionsType()
32			{
33			$filterLoaders = new ServiceManager;
34			$chainLoader = new Chain($filterLoaders);
35			$this->setExpectedException('HtImgModule\Exception\InvalidArgumentException');
			0 ignored issues – show Deprecated Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report The method `PHPUnit_Framework_TestCase::setExpectedException()` has been deprecated with message: Method deprecated since Release 5.2.0; use expectException() instead This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
36			$chainFilter = $chainLoader->load(['filters' => '']);
			0 ignored issues – show Unused Code introduced 2018-04-27 18:36 UTC by Report Bug Copy Issue Report `$chainFilter` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37			}
38			}
39

hrevert / HtImgModule

GitHub Access Token became invalid

Pull Request — master (#34)

ChainTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like