HtImgModule\Imagine\Loader\GaufretteLoader::load()

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes

0

<?php
    public function load($path)
    {
        try {
            $contents = $this->filesystem->read($path);

The expression $this->filesystem->read($path); of type string|boolean adds the type boolean to the return on line 45 which is incompatible with the return type declared by the interface HtImgModule\Imagine\Loader\LoaderInterface::load of type HtImgModule\Binary\Binary|string.

        } catch (FileNotFoundException $e) {
            throw new Exception\ImageNotFoundException(sprintf('Source image not found in "%s"', $path));
        }

        try {
            $mimeType = $this->filesystem->mimeType($path);
        } catch (\LogicException $e) {
            // Mime Type could not be detected
            return $contents;
        }

        if (!$mimeType) {
            // Mime Type could not be detected
            return $contents;
        }

        return new Binary($contents, $mimeType);

It seems like $contents defined by $this->filesystem->read($path) on line 36 can also be of type boolean; however, HtImgModule\Binary\Binary::__construct() does only seem to accept string, maybe add an additional type check?

    }
}