HtImgModule\Controller\ImageController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

87.5%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	displayAction()	0	21	6

<?php
namespace HtImgModule\Controller;

use Zend\Mvc\Controller\AbstractActionController;
use HtImgModule\Service\ImageServiceInterface;
use HtImgModule\View\Model\ImageModel;
use HtImgModule\Exception;

class ImageController extends AbstractActionController
{
    /**
     * @var ImageServiceInterface
     */
    protected $imageService;

    /**
     * Constructor
     *
     * @param ImageServiceInterface $imageService
     */
    public function __construct(ImageServiceInterface $imageService)
    {
        $this->imageService = $imageService;
    }

    /**
     * Displays image
     */
    public function displayAction()
    {
        $relativePath = $this->plugin('params')->fromQuery('relativePath');

The method fromQuery() does not seem to exist on object<Zend\Stdlib\DispatchableInterface>.

        $filter       = $this->plugin('params')->fromRoute('filter');

The method fromRoute() does not seem to exist on object<Zend\Stdlib\DispatchableInterface>.

        if (!$relativePath || !$filter) {
            return $this->notFoundAction();
        }
        try {
            $imageData = $this->imageService->getImage($relativePath, $filter);
        } catch (Exception\ImageNotFoundException $e) {
            return $this->notFoundAction();
        } catch (Exception\FilterNotFoundException $e) {
            return $this->notFoundAction();
        }

        if (!$imageData) {

The expression $imageData of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->notFoundAction();
        }

        return new ImageModel($imageData['image'], $imageData['format'], $imageData['imageOutputOptions']);
    }
}