HtImgModule\Imagine\Filter\Background

Complexity

Total Complexity

3

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	apply()	0	20	2

<?php
namespace HtImgModule\Imagine\Filter;

use Imagine\Filter\FilterInterface;
use Imagine\Image\ImageInterface;
use Imagine\Image\ImagineInterface;
use Imagine\Image\Box;
use Imagine\Image\Point;

class Background implements FilterInterface
{
    /**
     * @var ImagineInterface
     */
    protected $imagine;

    /**
     * @var array|int[]
     */
    protected $size;

    /**
     * @var string
     */
    protected $color;

    /**
     * Constructor
     *
     * @param ImagineInterface $imagine
     * @param array|int[]      $size
     * @param string           $color
     */
    public function __construct(ImagineInterface $imagine, $size = null, $color = '#fff')
    {
        $this->imagine  = $imagine;
        $this->size     = $size;

It seems like $size can be null. However, the property $size is declared as array. Maybe change the type of the property to array|null or add a type check?

        $this->color    = $color;
    }

    /**
     * {@inheritDoc}
     */
    public function apply(ImageInterface $image)
    {
        if ($this->size) {

The expression $this->size of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            list($width, $height) = $this->size;

            $size = new Box($width, $height);
            $topLeft = new Point(
                ($width - $image->getSize()->getWidth()) / 2,
                ($height - $image->getSize()->getHeight()) / 2
            );
        } else {
            $topLeft = new Point(0, 0);
            $size = $image->getSize();
        }

        $background = $image->palette()->color($this->color);
        $canvas = $this->imagine->create($size, $background);

        return $canvas->paste($image, $topLeft);
    }
}