Issues in Signature.php (master) - Issues in master - hoymultimedia/PHP-Caspeco - Measure and Improve Code Quality continuously with Scrutinizer

Issues (8)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Signature.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of Caspeco.
 *
 (c) HOY Multimedia AB <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Hoy\Caspeco\Http;

use DateTime;
use DateTimeZone;
use Psr\Http\Message\RequestInterface;

/**
 * This is the signature middleware class.
 *
 * @author Vincent Klaiber <[email protected]>
 */
final class Signature
{
    /**
     * The client id.
     *
     * @var string
     */
    protected $id;

    /**
     * The client secret.
     *
     * @var string
     */
    protected $secret;

    /**
     * The client url.
     *
     * @var string
     */
    protected $url;

    /**
     * Create a new signature instance.
     *
     * @param string $id
     * @param string $secret
     * @param string $url
     */
    public function __construct($id, $secret, $url)
    {
        $this->id = $id;
        $this->secret = $secret;
        $this->url = $url;
    }

    /**
     * Sign given request.
     *
     * @param \Psr\Http\Message\RequestInterface $request
     *
     * @return \Psr\Http\Message\RequestInterface
     */
    public function sign(RequestInterface $request)
    {
        $request = $request->withHeader('Accept', 'application/json; charset=utf-8');

        $host = $this->getHostFromUrl($this->url);
        $request = $request->withHeader('Host', $host);

        $date = $this->formatDate(new DateTime('now', new DateTimeZone('GMT')));
        $request = $request->withHeader('Date', $date);

        $body = strtolower($request->getMethod()) === 'get' ? '' : $request->getBody()->getContents();
        $digest = $this->hashDigest($body);
        $request = $request->withHeader('Digest', $digest);

        $target = strtolower(sprintf('%s %s', $request->getMethod(), $request->getRequestTarget()));
        $signature = "(request-target): {$target}\nhost: {$host}\ndate: {$date}\ndigest: {$digest}";

        $request = $request->withHeader('Authorization', $this->authorizeSignature($signature));

        return $request;
    }

    /**
     * Get the authorization header.
     *
     * @param $signature
     *
     * @return string
     */
    protected function authorizeSignature($signature)
    {
        $hash = base64_encode(hash_hmac('sha256', $signature, base64_decode($this->secret), true));

        return sprintf('Signature keyId="%s",algorithm="hmac-sha256",headers="(request-target) host date digest",signature="%s"', $this->id, $hash);

    }

    /**
     * Get the date header.
     *
     * @param \DateTime $time
     *
     * @return string
     */
    protected function formatDate(DateTime $time)
    {
        return $time->format('D, d M Y H:i:s').' GMT';
    }

    /**
     * Get the hash header.
     *
     * @param string $body
     *
     * @return string
     */
    protected function hashDigest($body)
    {
        return 'SHA-256='.base64_encode(hash('sha256', $body, true));
    }

    /**
     * Get the host header.
     *
     * @param string $url
     *
     * @return string
     */
    protected function getHostFromUrl($url)
    {
        preg_match('/([a-z0-9\-]+\.){1,2}[a-z]{2,4}/', $url, $matches);

        return $matches[0];
    }
}


1			<?php
2
3			/*
4			* This file is part of Caspeco.
5			*
6			(c) HOY Multimedia AB <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Hoy\Caspeco\Http;
13
14			use DateTime;
15			use DateTimeZone;
16			use Psr\Http\Message\RequestInterface;
17
18			/**
19			* This is the signature middleware class.
20			*
21			* @author Vincent Klaiber <[email protected]>
22			*/
23			final class Signature
24			{
25			/**
26			* The client id.
27			*
28			* @var string
29			*/
30			protected $id;
31
32			/**
33			* The client secret.
34			*
35			* @var string
36			*/
37			protected $secret;
38
39			/**
40			* The client url.
41			*
42			* @var string
43			*/
44			protected $url;
45
46			/**
47			* Create a new signature instance.
48			*
49			* @param string $id
50			* @param string $secret
51			* @param string $url
52			*/
53			public function __construct($id, $secret, $url)
54			{
55			$this->id = $id;
56			$this->secret = $secret;
57			$this->url = $url;
58			}
59
60			/**
61			* Sign given request.
62			*
63			* @param \Psr\Http\Message\RequestInterface $request
64			*
65			* @return \Psr\Http\Message\RequestInterface
66			*/
67			public function sign(RequestInterface $request)
68			{
69			$request = $request->withHeader('Accept', 'application/json; charset=utf-8');
70
71			$host = $this->getHostFromUrl($this->url);
72			$request = $request->withHeader('Host', $host);
73
74			$date = $this->formatDate(new DateTime('now', new DateTimeZone('GMT')));
75			$request = $request->withHeader('Date', $date);
76
77			$body = strtolower($request->getMethod()) === 'get' ? '' : $request->getBody()->getContents();
78			$digest = $this->hashDigest($body);
79			$request = $request->withHeader('Digest', $digest);
80
81			$target = strtolower(sprintf('%s %s', $request->getMethod(), $request->getRequestTarget()));
82			$signature = "(request-target): {$target}\nhost: {$host}\ndate: {$date}\ndigest: {$digest}";
83
84			$request = $request->withHeader('Authorization', $this->authorizeSignature($signature));
85
86			return $request;
87			}
88
89			/**
90			* Get the authorization header.
91			*
92			* @param $signature
93			*
94			* @return string
95			*/
96			protected function authorizeSignature($signature)
97			{
98			$hash = base64_encode(hash_hmac('sha256', $signature, base64_decode($this->secret), true));
99
100			return sprintf('Signature keyId="%s",algorithm="hmac-sha256",headers="(request-target) host date digest",signature="%s"', $this->id, $hash);
			0 ignored issues – show Coding Style introduced 2016-11-04 13:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this This line exceeds maximum limit of 120 characters; contains 148 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
101			}
102
103			/**
104			* Get the date header.
105			*
106			* @param \DateTime $time
107			*
108			* @return string
109			*/
110			protected function formatDate(DateTime $time)
111			{
112			return $time->format('D, d M Y H:i:s').' GMT';
113			}
114
115			/**
116			* Get the hash header.
117			*
118			* @param string $body
119			*
120			* @return string
121			*/
122			protected function hashDigest($body)
123			{
124			return 'SHA-256='.base64_encode(hash('sha256', $body, true));
125			}
126
127			/**
128			* Get the host header.
129			*
130			* @param string $url
131			*
132			* @return string
133			*/
134			protected function getHostFromUrl($url)
135			{
136			preg_match('/([a-z0-9\-]+\.){1,2}[a-z]{2,4}/', $url, $matches);
137
138			return $matches[0];
139			}
140			}
141

hoymultimedia / PHP-Caspeco

Issues (8)

Security Analysis not enabled

src/Http/Signature.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like