AgaviDisplayControllersTask

Complexity

Total Complexity

8

Size/Duplication

Total Lines	72
Duplicated Lines	15.28 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	setPath()	0	4	1
B	main()	11	54	7

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 32 and the first side effect is on line 16.

// +---------------------------------------------------------------------------+
// | This file is part of the Agavi package.                                   |
// | Copyright (c) 2005-2011 the Agavi Project.                                |
// |                                                                           |
// | For the full copyright and license information, please view the LICENSE   |
// | file that was distributed with this source code. You can also view the    |
// | LICENSE file online at http://www.agavi.org/LICENSE.txt                   |
// |   vi: set noexpandtab:                                                    |
// |   Local Variables:                                                        |
// |   indent-tabs-mode: t                                                     |
// |   End:                                                                    |
// +---------------------------------------------------------------------------+

require_once(__DIR__ . '/AgaviTask.php');

/**
 * Displays all controllers in an Agavi module.
 *
 * @package    agavi
 * @subpackage build
 *
 * @author     Noah Fontes <noah.fontes@bitextender.com>
 * @copyright  Authors
 * @copyright  The Agavi Project
 *
 * @since      1.0.0
 *
 * @version    $Id$
 */
class AgaviDisplayControllersTask extends AgaviTask

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
	protected $path = null;
	
	/**
	 * Sets the path to the project directory from which this task will read.
	 *
	 * @param      PhingFile Path to the project directory.
	 */
	public function setPath(PhingFile $path)
	{
		$this->path = $path;
	}
	
	/**
	 * Executes this task.
	 */
	public function main()
	{
		if($this->path === null) {
			throw new \Agavi\Build\Exception\BuildException('The path attribute must be specified');
		}
		
		$check = new \Agavi\Build\Check\ModuleFilesystemCheck();
		$check->setConfigDirectory($this->project->getProperty('module.config.directory'));
		
		$check->setPath($this->path->getAbsolutePath());
		if(!$check->check()) {
			throw new \Agavi\Build\Exception\BuildException('The path attribute must be a valid module base directory');
		}
		
		/* We don't know whether the module is configured or not here, so load the
		 * values we want properly. */
		$this->tryLoadAgavi();
		$this->tryBootstrapAgavi();
		
		require_once(\Agavi\Config\ConfigCache::checkConfig(
			sprintf('%s/%s/module.xml',
				$this->path->getAbsolutePath(),
				(string)$this->project->getProperty('module.config.directory')
			)
		));
		
		$controllerPath = \Agavi\Util\Toolkit::expandVariables(
			\Agavi\Util\Toolkit::expandDirectives(\Agavi\Config\Config::get(
				sprintf('modules.%s.agavi.controller.path', strtolower($this->path->getName())),
				'%core.module_dir%/${moduleName}/controllers/${controllerName}Controller.class.php'
			)),
			array(
				'moduleName' => $this->path->getName()
			)
		);
		$pattern = '#^' . \Agavi\Util\Toolkit::expandVariables(
			/* Blaaaaaaaaauuuuuughhhhhhh... */
			str_replace('\\$\\{controllerName\\}', '${controllerName}', preg_quote($controllerPath, '#')),
			array('controllerName' => '(?P<controller_name>.*?)')
		) . '$#';
		
		$iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->path->getAbsolutePath()));
		for(; $iterator->valid(); $iterator->next()) {

This code seems to be duplicated across your project.

			$rdi = $iterator->getInnerIterator();
			if($rdi->isDot() || !$rdi->isFile()) {
				continue;
			}
			
			$file = $rdi->getPathname();
			if(preg_match($pattern, $file, $matches)) {
				$this->log(str_replace(DIRECTORY_SEPARATOR, '.', $matches['controller_name']));
			}
		}
	}
}

?>

It is not recommended to use PHP's closing tag ?> in files other than templates.