Agavi\Validator\NumberValidator

Complexity

Total Complexity

27

Size/Duplication

Total Lines	94
Duplicated Lines	8.51 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
F	validate()	8	82	27

<?php
namespace Agavi\Validator;

// +---------------------------------------------------------------------------+
// | This file is part of the Agavi package.                                   |
// | Copyright (c) 2005-2011 the Agavi Project.                                |
// |                                                                           |
// | For the full copyright and license information, please view the LICENSE   |
// | file that was distributed with this source code. You can also view the    |
// | LICENSE file online at http://www.agavi.org/LICENSE.txt                   |
// |   vi: set noexpandtab:                                                    |
// |   Local Variables:                                                        |
// |   indent-tabs-mode: t                                                     |
// |   End:                                                                    |
// +---------------------------------------------------------------------------+
use Agavi\Config\Config;
use Agavi\Util\DecimalFormatter;

/**
 * NumberValidator verifies that a parameter is a number and allows you to
 * apply size constraints.
 *
 * Parameters:
 *   'no_locale' do not use localized number format parsing with translation on
 *   'in_locale' locale to use for parsing rather than the current locale
 *   'type'      number type (int/integer or double/float)
 *   'cast_to'   type to cast to (int/integer or double/float)
 *   'min'       minimum value for the input
 *   'max'       maximum value for the input
 *
 * @package    agavi
 * @subpackage validator
 *
 * @author     Dominik del Bondio <ddb@bitxtender.com>
 * @copyright  Authors
 * @copyright  The Agavi Project
 *
 * @since      0.11.0
 *
 * @version    $Id$
 */
class NumberValidator extends Validator
{
    /**
     * Validates the input
     *
     * @return     bool The input is valid number according to given parameters.
     *
     * @author     Dominik del Bondio <ddb@bitxtender.com>
     * @author     David Zülke <david.zuelke@bitextender.com>
     * @since      0.11.0
     */
    protected function validate()
    {
        $value =& $this->getData($this->getArgument());

        if (!is_scalar($value)) {
            // non scalar values would cause notices
            $this->throwError();
            return false;
        }

        $hasExtraChars = false;
        if (!is_int($value) && !is_float($value)) {
            $locale = null;
            if (Config::get('core.use_translation') && !$this->getParameter('no_locale', false)) {
                if ($locale = $this->getParameter('in_locale')) {
                    $locale = $this->getContext()->getTranslationManager()->getLocale($locale);
                } else {
                    $locale = $this->getContext()->getTranslationManager()->getCurrentLocale();
                }
            }
            
            $parsedValue = DecimalFormatter::parse($value, $locale, $hasExtraChars);

$value is of type string|boolean, but the function expects a object<Agavi\Util\The>.

It seems like $locale can also be of type object<Agavi\Translation\Locale>; however, Agavi\Util\DecimalFormatter::parse() does only seem to accept object<Agavi\Util\An>|null, maybe add an additional type check?

        } else {
            $parsedValue = $value;
        }
        
        switch (strtolower($this->getParameter('type'))) {
            case 'int':
            case 'integer':
                if (!is_int($parsedValue) || $hasExtraChars) {
                    $this->throwError('type');
                    return false;
                }
                
                break;
            
            case 'float':
            case 'double':
                if ((!is_float($parsedValue) && !is_int($parsedValue)) || $hasExtraChars) {
                    $this->throwError('type');
                    return false;
                }
                
                break;
            
            default:
                if ($parsedValue === false || $hasExtraChars) {
                    $this->throwError('type');
                    return false;
                }
        }

        if ($this->hasParameter('min') && $parsedValue < $this->getParameter('min')) {

This code seems to be duplicated across your project.

            $this->throwError('min');
            return false;
        }

        if ($this->hasParameter('max') && $parsedValue > $this->getParameter('max')) {

This code seems to be duplicated across your project.

            $this->throwError('max');
            return false;
        }
        
        switch (strtolower($this->getParameter('cast_to', $this->getParameter('type')))) {
            case 'int':
            case 'integer':
                $parsedValue = (int) $parsedValue;
                break;
            
            case 'float':
            case 'double':
                $parsedValue = (float) $parsedValue;
                break;
        }

        if ($this->hasParameter('export')) {
            $this->export($parsedValue);
        } else {
            $value = $parsedValue;
        }
        
        return true;
    }
}