hooman-mirghasemi / Laravel-iran-sms

src/Drivers/Kavenegar.php

<?php

namespace HoomanMirghasemi\Sms\Drivers;

use HoomanMirghasemi\Sms\Abstracts\Driver;
use Kavenegar\KavenegarApi;

class Kavenegar extends Driver
{
    protected string $from = '';

    public function __construct(protected array $settings, private KavenegarApi $kavenegarApi)
    {
    }

    public function getBalance(): string
    {
        return '';
    }

    public function send(): bool
    {
        try {
            if ($this->message->usesTemplate()) {

The method usesTemplate() does not exist on HoomanMirghasemi\Sms\Contracts\Message. Since it exists in all sub-types, consider adding an abstract or default implementation to HoomanMirghasemi\Sms\Contracts\Message.

                $template = $this->message->getTemplate();

The method getTemplate() does not exist on HoomanMirghasemi\Sms\Contracts\Message. Since it exists in all sub-types, consider adding an abstract or default implementation to HoomanMirghasemi\Sms\Contracts\Message.

                $identifier = $template['identifier'];
                $params = $template['params'];
                $token1 = str_replace(' ', '-', $params['token1'] ?? '');
                $token2 = str_replace(' ', '-', $params['token2'] ?? '');
                $token3 = str_replace(' ', '-', $params['token3'] ?? '');

                $token10 = $this->replaceExtraSpace($params['token10'] ?? '', 4);
                $token20 = $this->replaceExtraSpace($params['token20'] ?? '', 8);

                $result = $this->kavenegarApi->VerifyLookup(
                    $this->recipient,
                    $token1,
                    $token2,
                    $token3,
                    $identifier,
                    null,
                    $token10,
                    $token20
                );
            } else {
                $result = $this->kavenegarApi->Send(null, $this->recipient, $this->message->toString());
            }

            $this->success = true;
            $this->from = $result[0]->sender;
            $this->message = $result[0]->message;
            $this->webserviceResponse = print_r($result, true);

It seems like print_r($result, true) can also be of type true. However, the property $webserviceResponse is declared as type string. Maybe add an additional type check?

        } catch (\Exception $exception) {
            $this->webserviceResponse = $exception->getMessage();
            $this->success = false;
        }

        return parent::send();
    }

    private function replaceExtraSpace($string, $maxSpace)
    {
        $spaceCount = substr_count($string, ' ');
        if ($spaceCount > $maxSpace) {
            $string = strrev(preg_replace('/ /', '-', strrev($string), $spaceCount - $maxSpace));
        }

        return $string;
    }
}