honeybadger-io / honeybadger-laravel

src/ContextManager.php

<?php

namespace Honeybadger\HoneybadgerLaravel;

use Honeybadger\Contracts\Reporter;
use Illuminate\Support\Facades\Route;
use Symfony\Component\HttpFoundation\Request;

class ContextManager
{
    /**
     * @var \Honeybadger\Honeybadger;
     */
    protected $honeybadger;

    /**
     * @param  \Honeybadger\Contracts\Reporter  $honeybadger
     */
    public function __construct(Reporter $honeybadger)
    {
        $this->honeybadger = $honeybadger;

$honeybadger is of type Honeybadger\Contracts\Reporter, but the property $honeybadger was declared to be of type Honeybadger\Honeybadger. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    public function setRouteAction(Request $request)
    {
        if (app('honeybadger.isLumen')) {
            $this->setLumenRouteActionContext($request);
        } else {
            $this->setLaravelRouteActionContext();
        }
    }

    private function setLumenRouteActionContext(Request $request)
    {
        $routes = app()->router->getRoutes();
        $routeIdentifier = $request->method().$request->getPathInfo();

The method method() does not exist on Symfony\Component\HttpFoundation\Request. Are you sure you never get this type here, but always one of the subclasses?

        if (! array_key_exists($routeIdentifier, $routes)) {
            return;
        }

        $routeDetails = $routes[$routeIdentifier]['action'];

        if (! isset($routeDetails['uses']) && ! empty($routeDetails[0])) {
            $this->honeybadger->setComponent(get_class($routeDetails[0]));

            return;
        }

        $routeAction = explode('@', $routeDetails['uses']);

        if (! empty($routeAction[0])) {
            $this->honeybadger->setComponent($routeAction[0] ?? '');
        }

        if (! empty($routeAction[1])) {
            $this->honeybadger->setAction($routeAction[1] ?? '');
        }
    }

    private function setLaravelRouteActionContext()
    {
        if (Route::getCurrentRoute()) {
            $routeAction = explode('@', Route::getCurrentRoute()->getActionName());

            if (! empty($routeAction[0])) {
                $this->honeybadger->setComponent($routeAction[0] ?? '');
            }

            if (! empty($routeAction[1])) {
                $this->honeybadger->setAction($routeAction[1] ?? '');
            }
        }
    }

    public function setUserContext($request)
    {
        try {
            if ($request->user()) {
                $this->honeybadger->context(
                    'user_id',
                    $request->user()->getAuthIdentifier()
                );
            }
        } catch (\InvalidArgumentException $e) {
            // swallow
        }
    }
}