HomeDesignShops\LaravelBolComRetailer\Models\Transport

Complexity

Total Complexity

5

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getCorrectTransportName()	0	16	4

<?php


namespace HomeDesignShops\LaravelBolComRetailer\Models;


class Transport
{
    /**
     * @var string
     */
    public $transporterCode;

    /**
     * @var string
     */
    public $trackingCode;

    /**
     * The key is de Bol.com shipment name.
     * The values will be mapped to the correct shipment name.
     *
     * @var array
     */
    protected $transportCodes = [
        'tnt' => [
            'postnl',
        ],
        'gls' => []
    ];

    /**
     * TransportItem constructor.
     * @param string $transporterCode
     * @param string $trackingCode
     */
    public function __construct(string $transporterCode, string $trackingCode)
    {
        $this->transporterCode = $this->getCorrectTransportName($transporterCode);

It seems like $this->getCorrectTransportName($transporterCode) can also be of type integer or false. However, the property $transporterCode is declared as type string. Maybe add an additional type check?

        $this->trackingCode = $trackingCode;
    }

    /**
     * Returns the correct transport name.
     *
     * @param $name
     * @return bool|int|string
     */
    protected function getCorrectTransportName($name)
    {
        $name = strtolower($name);

        if(isset($this->shipmentMapping[$name])) {

The property shipmentMapping does not exist. Did you maybe forget to declare it?

            return $name;
        }

        foreach ($this->transportCodes as $key => $shipments) {
            if(in_array($name, $shipments, true)) {
                return $key;
            }
        }

        return false;
    }
}