App\Tests\Unit\EventSubscriber\AmpOptimizerSubscriberTest

Complexity

Total Complexity

9

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testSubscribedEvents()	0	5	1
A	getInstance()	0	24	3
A	testTransformRequest()	0	5	1
A	testNotMasterRequest()	0	5	1
A	getEventNotMasterRequestMocked()	0	7	1
A	getEventMasterRequestMocked()	0	14	1
A	setUp()	0	3	1

<?php

Class found in ".php" file; use ".inc" extension instead

This file is missing a doc comment.

The PHP open tag does not have a corresponding PHP close tag

Filename "AmpOptimizerSubscriberTest.php" doesn't match the expected filename "ampoptimizersubscribertest.php"

Missing file doc comment

namespace App\Tests\Unit\EventSubscriber;

use AmpProject\Optimizer\ErrorCollection;
use AmpProject\Optimizer\TransformationEngine;
use DG\BypassFinals;
use Hola\AmpToolboxBundle\EventSubscriber\AmpOptimizerSubscriber;
use PHPUnit\Framework\TestCase;

The type PHPUnit\Framework\TestCase was not found. Maybe you did not declare it correctly or list all dependencies?

use Prophecy\Argument;
use Psr\Log\LoggerInterface;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Event\ResponseEvent;
use Symfony\Component\HttpKernel\KernelEvents;

class AmpOptimizerSubscriberTest extends TestCase

Missing doc comment for class AmpOptimizerSubscriberTest

{

Opening brace should be on the same line as the declaration for class AmpOptimizerSubscriberTest

    public function setUp(): void

Expected 2 blank lines before function; 0 found

Missing doc comment for function setUp()

    {

Opening brace should be on the same line as the declaration

        BypassFinals::enable();
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end setUp()

    public function testSubscribedEvents()

Missing doc comment for function testSubscribedEvents()

    {

Opening brace should be on the same line as the declaration

        $events = AmpOptimizerSubscriber::getSubscribedEvents();

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

        $eventsExpected = [KernelEvents::RESPONSE => ['onKernelResponse', -10]];

Arrays with multiple values should not be declared on a single line.

Short array syntax is not allowed

        $this->assertEquals($events, $eventsExpected);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end testSubscribedEvents()

    public function testNotMasterRequest()

Missing doc comment for function testNotMasterRequest()

    {

Opening brace should be on the same line as the declaration

        $instance = $this->getInstance(false);

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

        $event = $this->getEventNotMasterRequestMocked();

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $instance->onKernelResponse($event);
    }

Expected 1 blank line before closing function brace; 0 found

Expected //end testNotMasterRequest()

    public function testTransformRequest()

Missing doc comment for function testTransformRequest()

    {

Opening brace should be on the same line as the declaration

        $instance = $this->getInstance();
        $event = $this->getEventMasterRequestMocked();

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

        $instance->onKernelResponse($event);
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end testTransformRequest()

    /**

Missing short description in doc comment

     * @param bool $transform

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

Expected "boolean" but found "bool" for parameter type

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @param array $config

Missing parameter comment

Tag value for @param tag indented incorrectly; expected 2 spaces but found 1

     * @return AmpOptimizerSubscriber

Tag @return cannot be grouped with parameter tags in a doc comment

     */
    private function getInstance($transform = true, $config = []): AmpOptimizerSubscriber

Private method name "AmpOptimizerSubscriberTest::getInstance" must be prefixed with an underscore

Type hint "bool" missing for $transform

Type hint "array" missing for $config

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

Short array syntax is not allowed

    {

Opening brace should be on the same line as the declaration

        $logger = $this->prophesize(LoggerInterface::class);

        $transformationEngine = $this->prophesize(TransformationEngine::class);

        if ($transform) {
            $transformationEngine->optimizeHtml(
                Argument::type('string'),
                Argument::type(ErrorCollection::class)
            )->shouldBeCalled();
        }

        if (!$transform) {

Expected 1 space(s) after NOT operator; 0 found

            $transformationEngine->optimizeHtml(
                Argument::type('string'),
                Argument::type(ErrorCollection::class)
            )->shouldNotBeCalled();
        }

        return new AmpOptimizerSubscriber(
            $logger->reveal(),
            $transformationEngine->reveal(),
            $config
        );
    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getInstance()

    /**

Missing short description in doc comment

     * @return ResponseEvent
     */
    private function getEventMasterRequestMocked(): ResponseEvent

Private method name "AmpOptimizerSubscriberTest::getEventMasterRequestMocked" must be prefixed with an underscore

    {

Opening brace should be on the same line as the declaration

        /** @var Response $response */

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Block comments must be started with /*

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

        $response = $this->prophesize(Response::class);
        $response->getContent()->shouldBeCalled()->willReturn('html');
        $response->setContent(null)->shouldBeCalled();

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of null please use NULL.

The method shouldBeCalled() does not exist on Symfony\Component\HttpFoundation\Response.

        $response = $response->reveal();

The method reveal() does not exist on Symfony\Component\HttpFoundation\Response.

        /** @var ResponseEvent $event */

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Block comments must be started with /*

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

        $event = $this->prophesize(ResponseEvent::class);
        $event->isMasterRequest()->shouldBeCalled()->willReturn(true);

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of true please use TRUE.

        $event->getResponse()->shouldBeCalled()->willReturn($response);;

It is generally recommended to place each PHP statement on a line by itself.

        return $event->reveal();

The method reveal() does not exist on Symfony\Component\HttpKernel\Event\ResponseEvent.

    }

Expected 2 blank lines after function; 1 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getEventMasterRequestMocked()

    /**

Missing short description in doc comment

     * @return ResponseEvent
     */
    private function getEventNotMasterRequestMocked(): ResponseEvent

Private method name "AmpOptimizerSubscriberTest::getEventNotMasterRequestMocked" must be prefixed with an underscore

    {

Opening brace should be on the same line as the declaration

        /** @var ResponseEvent $event */

Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead

Block comments must be started with /*

The open comment tag must be the only content on the line

Missing short description in doc comment

The close comment tag must be the only content on the line

        $event = $this->prophesize(ResponseEvent::class);
        $event->isMasterRequest()->shouldBeCalled()->willReturn(false);

TRUE, FALSE and NULL should be uppercase as per the configured coding-style; instead of false please use FALSE.

        $event->getResponse()->shouldNotBeCalled();

The method shouldNotBeCalled() does not exist on Symfony\Component\HttpFoundation\Response.

        return $event->reveal();
    }

Expected 2 blank lines after function; 0 found

Expected 1 blank line before closing function brace; 0 found

Expected //end getEventNotMasterRequestMocked()

}

Expected //end class

As per coding style, files should not end with a newline character.