MonitorApplicationConfig::configure() - Code Metrics - Inspection of "Refactoring + test" - hogosha/monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f2fad...dd1cd3 )

by Guillaume

created 2016-01-12 09:40 UTC

MonitorApplicationConfig::configure() B

↳ Parent: MonitorApplicationConfig

Complexity

Conditions	1
Paths	1

Size

Total Lines	43
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	43
rs	8.8571
cc	1
eloc	27
nc	1
nop	0

<?php

namespace Hogosha\Monitor\Console;

use Hogosha\Monitor\Client\GuzzleClient;
use Hogosha\Monitor\Configuration\ConfigurationDumper;
use Hogosha\Monitor\Configuration\ConfigurationLoader;
use Hogosha\Monitor\Console\Handler\InitHandler;
use Hogosha\Monitor\Console\Handler\RunHandler;
use Hogosha\Monitor\Model\UrlProvider;
use Hogosha\Monitor\Monitor;
use Hogosha\Monitor\Runner\Runner;
use Webmozart\Console\Api\Args\Format\Option;
use Webmozart\Console\Config\DefaultApplicationConfig;

/**
 * @author Guillaume Cavana <[email protected]>
 */
class MonitorApplicationConfig extends DefaultApplicationConfig
{

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        parent::configure();

        $configurationLoader =  new ConfigurationLoader(
            rtrim(getcwd(), DIRECTORY_SEPARATOR),
            Monitor::CONFIG_FILENAME
        );
        $configurationDumper = new ConfigurationDumper();

        $runner = new Runner(
            new UrlProvider($configurationLoader),
            GuzzleClient::createClient()
        );

        $signature = <<<SIGNATURE
  _____                             _
 |_   _|                           | |
   | |  _ __ ___  _ __   __ _  __ _| |_ ___
   | | | '__/ _ \| '_ \ / _` |/ _` | __/ _ \
  _| |_| | | (_) | | | | (_| | (_| | ||  __/
 |_____|_|  \___/|_| |_|\__, |\__,_|\__\___|
                         __/ |
                        |___/
SIGNATURE;

        $this
            ->setDisplayName($signature."\n".'Irongate Monitor Application')
            ->setName('monitor')
            ->setVersion(Monitor::VERSION)
                ->beginCommand('init')
                    ->setDescription('Create a default configuration file if you do not have one')
                    ->setHandler(new InitHandler($configurationLoader, $configurationDumper))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    ->setHelp('php <info>bin/monitor</info> init')
                ->end()
                ->beginCommand('run')
                    ->setDescription('Launch the monitor process')
                    ->setHandler(new RunHandler($runner))
                    ->setHelp('php <info>bin/monitor</info> init')
                    ->addOption('format', null, Option::OPTIONAL_VALUE, 'The formatter', 'table')
                ->end()
        ;
    }
}


1			<?php
2
3			namespace Hogosha\Monitor\Console;
4
5			use Hogosha\Monitor\Client\GuzzleClient;
6			use Hogosha\Monitor\Configuration\ConfigurationDumper;
7			use Hogosha\Monitor\Configuration\ConfigurationLoader;
8			use Hogosha\Monitor\Console\Handler\InitHandler;
9			use Hogosha\Monitor\Console\Handler\RunHandler;
10			use Hogosha\Monitor\Model\UrlProvider;
11			use Hogosha\Monitor\Monitor;
12			use Hogosha\Monitor\Runner\Runner;
13			use Webmozart\Console\Api\Args\Format\Option;
14			use Webmozart\Console\Config\DefaultApplicationConfig;
15
16			/**
17			* @author Guillaume Cavana <[email protected]>
18			*/
19			class MonitorApplicationConfig extends DefaultApplicationConfig
20			{
21
22			/**
23			* {@inheritdoc}
24			*/
25			protected function configure()
26			{
27			parent::configure();
28
29			$configurationLoader = new ConfigurationLoader(
30			rtrim(getcwd(), DIRECTORY_SEPARATOR),
31			Monitor::CONFIG_FILENAME
32			);
33			$configurationDumper = new ConfigurationDumper();
34
35			$runner = new Runner(
36			new UrlProvider($configurationLoader),
37			GuzzleClient::createClient()
38			);
39
40			$signature = <<<SIGNATURE
41			_____ _
42			\|_ _\| \| \|
43			\| \| _ __ ___ _ __ __ _ __ _\| \|_ ___
44			\| \| \| '__/ _ \\| '_ \ / _` \|/ _` \| __/ _ \
45			_\| \|_\| \| \| (_) \| \| \| \| (_\| \| (_\| \| \|\| __/
46			\|_____\|_\| \___/\|_\| \|_\|\__, \|\__,_\|\__\___\|
47			__/ \|
48			\|___/
49			SIGNATURE;
50
51			$this
52			->setDisplayName($signature."\n".'Irongate Monitor Application')
53			->setName('monitor')
54			->setVersion(Monitor::VERSION)
55			->beginCommand('init')
56			->setDescription('Create a default configuration file if you do not have one')
57			->setHandler(new InitHandler($configurationLoader, $configurationDumper))
			0 ignored issues – show Bug introduced 2016-01-12 09:47 UTC by Report Bug Copy Issue Report The call to `InitHandler::__construct()` misses a required argument `$filesystem`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2016-01-12 09:47 UTC by Report Bug Copy Issue Report `new \Hogosha\Monitor\Con..., $configurationDumper)` is of type `object<Hogosha\Monitor\C...le\Handler\InitHandler>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58			->setHelp('php <info>bin/monitor</info> init')
59			->end()
60			->beginCommand('run')
61			->setDescription('Launch the monitor process')
62			->setHandler(new RunHandler($runner))
63			->setHelp('php <info>bin/monitor</info> init')
64			->addOption('format', null, Option::OPTIONAL_VALUE, 'The formatter', 'table')
65			->end()
66			;
67			}
68			}
69

hogosha / monitor

Push — master ( 4f2fad...dd1cd3 )

MonitorApplicationConfig::configure() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like