UrlProvider - Code Metrics - Inspection of "Refactoring + test" - hogosha/monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f2fad...dd1cd3 )

by Guillaume

created 2016-01-12 09:40 UTC

UrlProvider A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	3
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	35
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getUrls()	0	13	2

<?php

namespace Hogosha\Monitor\Model;

use Hogosha\Monitor\Configuration\ConfigurationLoader;
use Hogosha\Monitor\Model\UrlInfo;

/**
 * @author Guillaume Cavana <[email protected]>
 */
class UrlProvider
{
    /**
     * $configurationLoader.
     * @var ConfigurationLoader
     */
    protected $configurationLoader;

    /**
     * Constructor.
     * @param ConfigurationLoader $configurationLoader
     */
    public function __construct(ConfigurationLoader $configurationLoader)
    {
        $this->configurationLoader = $configurationLoader;
    }

    /**
     * getUrls.
     * @return array
     */
    public function getUrls()
    {
        $config = $this->configurationLoader->loadConfiguration();
        foreach ($config['urls'] as $name => $attribute) {
            $urls[] = new UrlInfo(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                $name,
                $attribute['url'],
                $attribute['timeout']
            );
        }

        return $urls;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


1			<?php
2
3			namespace Hogosha\Monitor\Model;
4
5			use Hogosha\Monitor\Configuration\ConfigurationLoader;
6			use Hogosha\Monitor\Model\UrlInfo;
7
8			/**
9			* @author Guillaume Cavana <[email protected]>
10			*/
11			class UrlProvider
12			{
13			/**
14			* $configurationLoader.
15			* @var ConfigurationLoader
16			*/
17			protected $configurationLoader;
18
19			/**
20			* Constructor.
21			* @param ConfigurationLoader $configurationLoader
22			*/
23			public function __construct(ConfigurationLoader $configurationLoader)
24			{
25			$this->configurationLoader = $configurationLoader;
26			}
27
28			/**
29			* getUrls.
30			* @return array
31			*/
32			public function getUrls()
33			{
34			$config = $this->configurationLoader->loadConfiguration();
35			foreach ($config['urls'] as $name => $attribute) {
36			$urls[] = new UrlInfo(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-11 20:49 UTC by Report Bug Copy Issue Report `$urls` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$urls = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
37			$name,
38			$attribute['url'],
39			$attribute['timeout']
40			);
41			}
42
43			return $urls;
			0 ignored issues – show Bug introduced 2016-01-11 20:49 UTC by Report Bug Copy Issue Report The variable `$urls` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
44			}
45			}
46

hogosha / monitor

Push — master ( 4f2fad...dd1cd3 )

UrlProvider A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like