StatusGuesserTest::createResult() - Code Metrics - Inspection of "Automatic hogosah portal update" - hogosha/monitor - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3592ed...983069 )

by Guillaume

created 2016-03-01 15:51 UTC

StatusGuesserTest::createResult() A

↳ Parent: StatusGuesserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Hogosha\Monitor\Renderer;

use Hogosha\Monitor\Guesser\StatusGuesser;
use Hogosha\Monitor\Model\Result;
use Hogosha\Monitor\Model\ResultCollection;
use Hogosha\Monitor\Model\UrlInfo;

/**
 * @author Guillaume Cavana <[email protected]>
 */
class StatusGuesserTest extends \PHPUnit_Framework_TestCase
{
    /**
     * testIsFailed.
     */
    public function testIsFailed()
    {
        $statusGuesser = new StatusGuesser();
        $this->assertTrue($statusGuesser->isFailed($this->createResult()));
    }

    /**
     * testIsOk.
     */
    public function testIsOk()
    {
        $statusGuesser = new StatusGuesser();
        $this->assertFalse($statusGuesser->isOk($this->createResult()));
    }

    /**
     * createResult.
     */
    public function createResult()
    {
        $result = new Result($this->createUrlInfo(), 200, 0.42);

        return $result;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    private function createUrlInfo()
    {
        return new UrlInfo(
            'Example',
            'http://example.com',
            'GET',
            [],
            1,
            404,
            null,
            null
        );
    }
}


1			<?php
2
3			namespace Hogosha\Monitor\Renderer;
4
5			use Hogosha\Monitor\Guesser\StatusGuesser;
6			use Hogosha\Monitor\Model\Result;
7			use Hogosha\Monitor\Model\ResultCollection;
8			use Hogosha\Monitor\Model\UrlInfo;
9
10			/**
11			* @author Guillaume Cavana <[email protected]>
12			*/
13			class StatusGuesserTest extends \PHPUnit_Framework_TestCase
14			{
15			/**
16			* testIsFailed.
17			*/
18			public function testIsFailed()
19			{
20			$statusGuesser = new StatusGuesser();
21			$this->assertTrue($statusGuesser->isFailed($this->createResult()));
22			}
23
24			/**
25			* testIsOk.
26			*/
27			public function testIsOk()
28			{
29			$statusGuesser = new StatusGuesser();
30			$this->assertFalse($statusGuesser->isOk($this->createResult()));
31			}
32
33			/**
34			* createResult.
35			*/
36			public function createResult()
37			{
38			$result = new Result($this->createUrlInfo(), 200, 0.42);
39
40			return $result;
			0 ignored issues – show Bug Best Practice introduced 2016-03-01 15:53 UTC by Report Bug Copy Issue Report The return type of `return $result;` (`Hogosha\Monitor\Model\Result`) is incompatible with the return type of the parent method `PHPUnit_Framework_TestCase::createResult` of type `PHPUnit_Framework_TestResult`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
41			}
42
43			private function createUrlInfo()
44			{
45			return new UrlInfo(
46			'Example',
47			'http://example.com',
48			'GET',
49			[],
50			1,
51			404,
52			null,
53			null
54			);
55			}
56			}
57

hogosha / monitor

Push — master ( 3592ed...983069 )

StatusGuesserTest::createResult() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like