PrioritizeTrait::sortRoutes() - Code Metrics - Inspection of "add support cache" - hnrazevedo/Router - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (b146cb)

by Henri

created 2020-10-04 19:02 UTC

PrioritizeTrait::sortRoutes() A

↳ Parent: PrioritizeTrait

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	4
eloc	14
nc	4
nop	0
dl	0
loc	26
rs	9.7998
c	1
b	0
f	1

<?php

declare(strict_types = 1);

namespace HnrAzevedo\Router;

trait PrioritizeTrait
{
    use Helper;

    protected bool $sorted = false;

    protected function sorted(?bool $sorted = null): bool
    {
        if(null !== $sorted){
            $this->sorted = $sorted;
        }
        return $this->sorted;
    }
    
    protected function sortRoutes(): bool
    {
        if($this->sorted()){
            return true;
        }

        $staticRoutes = [];
        $paramRoutes = [];

        foreach($this->getRoutes() as $r => $route){

            $path = urldecode(unserialize($route['uri'])->getPath());

            if(strstr($path,'{')){
                $paramRoutes[$this->getKeyArray(substr_count($path,'/') + substr_count($path,'{'),$paramRoutes)] = $route;
                continue;    
            }

            $staticRoutes[$this->getKeyArray(substr_count($path,'/'),$staticRoutes)] = $route;
        }

        rsort($paramRoutes);
        rsort($staticRoutes);

        $this->orderRoutes(array_merge($staticRoutes,$paramRoutes));
        return $this->sorted(true);
    }

    private function getKeyArray(int $index, array $array): int
    {
        while(array_key_exists($index,$array)){
            $index++;
        }
        return $index;
    }

    private function orderRoutes(array $routes):void
    {
        $kRoutes = $routes;
        foreach($routes as $r => $route){
            if(array_key_exists('name',$route)){
                unset($kRoutes[$r]);
                $kRoutes["'{$route['name']}'"] = $route;
            }
        }
        ksort($kRoutes);
        $this->setRoutes($kRoutes);
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace HnrAzevedo\Router;
6
7			trait PrioritizeTrait
8			{
9			use Helper;
10
11			protected bool $sorted = false;
12
13			protected function sorted(?bool $sorted = null): bool
14			{
15			if(null !== $sorted){
16			$this->sorted = $sorted;
17			}
18			return $this->sorted;
19			}
20
21			protected function sortRoutes(): bool
22			{
23			if($this->sorted()){
24			return true;
25			}
26
27			$staticRoutes = [];
28			$paramRoutes = [];
29
30			foreach($this->getRoutes() as $r => $route){
31
32			$path = urldecode(unserialize($route['uri'])->getPath());
33
34			if(strstr($path,'{')){
35			$paramRoutes[$this->getKeyArray(substr_count($path,'/') + substr_count($path,'{'),$paramRoutes)] = $route;
36			continue;
37			}
38
39			$staticRoutes[$this->getKeyArray(substr_count($path,'/'),$staticRoutes)] = $route;
40			}
41
42			rsort($paramRoutes);
43			rsort($staticRoutes);
44
45			$this->orderRoutes(array_merge($staticRoutes,$paramRoutes));
46			return $this->sorted(true);
47			}
48
49			private function getKeyArray(int $index, array $array): int
50			{
51			while(array_key_exists($index,$array)){
52			$index++;
53			}
54			return $index;
55			}
56
57			private function orderRoutes(array $routes):void
58			{
59			$kRoutes = $routes;
60			foreach($routes as $r => $route){
61			if(array_key_exists('name',$route)){
62			unset($kRoutes[$r]);
63			$kRoutes["'{$route['name']}'"] = $route;
64			}
65			}
66			ksort($kRoutes);
67			$this->setRoutes($kRoutes);
68			}
69			}
70

hnrazevedo / Router

Branch — master (b146cb)

PrioritizeTrait::sortRoutes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like