HnrAzevedo\Router\OwnerTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	unsetRoute()	0	4	1
A	loadIn()	0	5	1
A	runIn()	0	9	2
A	hasCurrentRoute()	0	4	2

<?php

namespace HnrAzevedo\Router;

trait OwnerTrait
{

    public function loadIn(string $name): RouterInterface
    {
        $this->hasRouteName($name);

It seems like hasRouteName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->loaded = true;

The property loaded does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;

The expression return $this returns the type HnrAzevedo\Router\OwnerTrait which is incompatible with the type-hinted return HnrAzevedo\Router\RouterInterface.

    }

    public function runIn(string $name): RouterInterface
    {
        $this->hasRouteName($name);

        if(!$this->loaded){
            $this->loadIn($name);
        }
        
        return $this;

The expression return $this returns the type HnrAzevedo\Router\OwnerTrait which is incompatible with the type-hinted return HnrAzevedo\Router\RouterInterface.

    }

    public function hasCurrentRoute(): void
    {
        if(!isset($this->currentRoute)){
            throw new \RuntimeException('Route not yet loaded');
        }
    }

    public function unsetRoute($key): RouterInterface
    {
        unset($this->routes[$key]);
        return $this;

The expression return $this returns the type HnrAzevedo\Router\OwnerTrait which is incompatible with the type-hinted return HnrAzevedo\Router\RouterInterface.

    }

}