HnrAzevedo\Router\MiddlewareTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	globalMiddlewares()	0	9	3
A	middleware()	0	7	3
A	existMiddleware()	0	4	3
A	process()	0	3	1

<?php

namespace HnrAzevedo\Router;

use Psr\Http\Server\RequestHandlerInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;
use HnrAzevedo\Http\Response;

trait MiddlewareTrait
{
    use Helper;

    protected static array $globalMiddlewares = [];

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface

The parameter $handler is not used and could be removed.

The parameter $request is not used and could be removed.

    {
        return new Response();
    }

    public static function globalMiddlewares(array $middlewares): RouterInterface
    {
        foreach($middlewares as $middleware){
            if(!class_exists($middleware)){
                throw new \RuntimeException("Middleware class {$middleware} not exists");
            }
        }
        self::getInstance()->middlewares = $middlewares;

The property middlewares does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return self::getInstance();
    }

    public static function middleware($middlewares): RouterInterface
    {
        $middlewares = (is_array($middlewares)) ? $middlewares : [ $middlewares ];
        $route = self::getInstance()->inSave();
        $route['middlewares'] = (is_array($route['middlewares'])) ? array_merge($route['middlewares'],$middlewares) : $middlewares;
        self::getInstance()->updateRoute($route,array_key_last(self::getInstance()->routes));

The property routes is declared protected in HnrAzevedo\Router\Router and cannot be accessed from this context.

        return self::getInstance();
    }

    private static function existMiddleware(string $name): void
    {
        if(!class_exists($name) && !array_key_exists($name,self::$globalMiddlewares)){
            throw new \RuntimeException("Middleware {$name} does not exist");
        }
    }


}