HnrAzevedo\Datamanager\MagicsTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__get()	0	16	6
A	get()	0	2	1
A	__set()	0	27	6

<?php

namespace HnrAzevedo\Datamanager;

trait MagicsTrait{

    public function __set(string $prop,$value)
    {
        if(is_array($value)){
            $attr = array_keys($value)[0];
            $this->data[$prop][$attr] = $value[$attr];

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return $this;
        }

        if($this->full){

The property full does not exist on HnrAzevedo\Datamanager\MagicsTrait. Since you implemented __get, consider adding a @property annotation.

            switch($this->data[$prop]['type']){
                case 'date':
                    $value = (date_format( date_create_from_format(DATAMANAGER_CONFIG['dateformat'],$value) , 'Y-m-d'));
                    break;
                case 'datetime':
                    $value = (date_format( date_create_from_format(DATAMANAGER_CONFIG['datetimeformat'],$value) , 'Y-m-d H:i:s'));
                    break;
            }
        }

        $this->isSettable($prop);

It seems like isSettable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->data[$prop]['changed'] = ($prop === $this->primary) ? false : true;

The property primary does not exist on HnrAzevedo\Datamanager\MagicsTrait. Since you implemented __get, consider adding a @property annotation.

        $this->data[$prop]['value'] = $value;
        
        $this->$prop = $value;
        
        return $this;
    }

    public function get(string $field){
        return $this->data[$field]['value'];
    }

    public function __get(string $field)
    {
        $this->isSettable($field);

        if($this->full){

The property full does not exist on HnrAzevedo\Datamanager\MagicsTrait. Since you implemented __get, consider adding a @property annotation.

            switch($this->data[$field]['type']){
                case 'date': 
                    return (!empty($this->data[$field]['value'])) ? (@date_format( @date_create_from_format('Y-m-d' , $this->data[$field]['value'] ) , DATAMANAGER_CONFIG['dateformat'])) : null ;
                    break;

break is not strictly necessary here and could be removed.

                case 'datetime': 
                    return (!empty($this->data[$field]['value'])) ? (@date_format( @date_create_from_format('Y-m-d H:i:s' , $this->data[$field]['value'] ) , DATAMANAGER_CONFIG['datetimeformat'])) : null ;
                    break;
            }
        }

        return $this->data[$field]['value'];
    }
}