ResetPasswordHandler::handle() - Code Metrics - Inspection of "Command Handlers" - hmlb/user-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 269c38...74a7a2 )

by Hugues

created 2016-02-20 17:56 UTC

ResetPasswordHandler::handle() A

↳ Parent: ResetPasswordHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	6
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	6
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php


declare (strict_types = 1);

namespace HMLB\UserBundle\Handler;

use HMLB\DDD\Message\Command\Command;
use HMLB\DDD\Message\Command\Handler;
use HMLB\UserBundle\Command\ResetPassword;
use HMLB\UserBundle\User\User;
use HMLB\UserBundle\User\UserRepository;
use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;

class ResetPasswordHandler implements Handler

{
    /**
     * @var UserRepository
     */
    private $userRepository;

    /**
     * @var UserPasswordEncoderInterface
     */
    private $encoder;

    /**
     * @param UserRepository               $userRepository
     * @param UserPasswordEncoderInterface $encoder
     */
    public function __construct(UserRepository $userRepository, UserPasswordEncoderInterface $encoder)
    {
        $this->userRepository = $userRepository;
        $this->encoder = $encoder;
    }

    /**
     * @param Command|ResetPassword $command
     */
    public function handle(Command $command)
    {
        /** @var User $user */
        $user = $this->userRepository->get($command->getUserId());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $user->resetPassword($command->getResetToken(), $command->getPassword(), $this->encoder);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


Push — master ( 269c38...74a7a2 )

ResetPasswordHandler::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-20 17:59 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 14 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		declare (strict_types = 1);
4
5		namespace HMLB\UserBundle\Handler;
6
7		use HMLB\DDD\Message\Command\Command;
8		use HMLB\DDD\Message\Command\Handler;
9		use HMLB\UserBundle\Command\ResetPassword;
10		use HMLB\UserBundle\User\User;
11		use HMLB\UserBundle\User\UserRepository;
12		use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
13
14	View Code Duplication	class ResetPasswordHandler implements Handler
		0 ignored issues – show Duplication introduced 2016-02-20 17:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16		/**
17		* @var UserRepository
18		*/
19		private $userRepository;
20
21		/**
22		* @var UserPasswordEncoderInterface
23		*/
24		private $encoder;
25
26		/**
27		* @param UserRepository $userRepository
28		* @param UserPasswordEncoderInterface $encoder
29		*/
30		public function __construct(UserRepository $userRepository, UserPasswordEncoderInterface $encoder)
31		{
32		$this->userRepository = $userRepository;
33		$this->encoder = $encoder;
34		}
35
36		/**
37		* @param Command\|ResetPassword $command
38		*/
39		public function handle(Command $command)
40		{
41		/** @var User $user */
42		$user = $this->userRepository->get($command->getUserId());
		0 ignored issues – show Bug introduced 2016-02-20 17:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `HMLB\DDD\Message\Command\Command` as the method `getUserId()` does only exist in the following sub-classes of `HMLB\DDD\Message\Command\Command`: `HMLB\UserBundle\Command\ChangeEmail`, `HMLB\UserBundle\Command\ChangePassword`, `HMLB\UserBundle\Command\ConfirmEmail`, `HMLB\UserBundle\Command\RequestEmailValidation`, `HMLB\UserBundle\Command\RequestPasswordReset`, `HMLB\UserBundle\Command\ResetPassword`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
43		$user->resetPassword($command->getResetToken(), $command->getPassword(), $this->encoder);
		0 ignored issues – show Bug introduced 2016-02-20 17:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `HMLB\DDD\Message\Command\Command` as the method `getResetToken()` does only exist in the following sub-classes of `HMLB\DDD\Message\Command\Command`: `HMLB\UserBundle\Command\ResetPassword`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string / abstract public function getDisplayName(); } Loading history... Bug introduced 2016-02-20 17:58 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `HMLB\DDD\Message\Command\Command` as the method `getPassword()` does only exist in the following sub-classes of `HMLB\DDD\Message\Command\Command`: `HMLB\UserBundle\Command\ChangePassword`, `HMLB\UserBundle\Command\RegisterUser`, `HMLB\UserBundle\Command\ResetPassword`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /* @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
44		}
45		}
46

hmlb / user-bundle

Push — master ( 269c38...74a7a2 )

ResetPasswordHandler::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like