AspectAuth::after() - Code Metrics - Inspection of "Add tests" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#31)

by Hiraku

created 2016-01-31 07:32 UTC

AspectAuth::after() B

↳ Parent: AspectAuth

Complexity

Conditions	7
Paths	7

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	21.5206

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
ccs	5
cts	15
cp	0.3333
rs	8.2222
cc	7
eloc	13
nc	7
nop	1
crap	21.5206

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo\Aspects;

use SplObserver;
use SplSubject;
use Composer\Downloader;

/**
 * Authentication aspects.
 */
class AspectAuth implements SplObserver
{
    public function update(SplSubject $ev)
    {
        switch ((string)$ev) {
            case 'pre-download':
                $this->before($ev->refRequest());
                break;
            case 'post-download':
                $this->after($ev->refResponse());
                break;
        }
    }

    public function before(HttpGetRequest $req)
    {
        if (!$req->username || !$req->password) {
            $req->username = null;
            $req->password = null;
            return;
        }

        switch ($req->special) {
            case 'github':
                if ($req->password === 'x-oauth-basic') {
                    $req->query['access_token'] = $req->username;
                    // forbid basic-auth
                    $req->username = null;
                    $req->password = null;
                    return;
                }
                break;
            case 'gitlab':
                if ($req->password === 'oauth2') {
                    $req->headers[] = 'Authorization: Bearer ' . $req->username;
                    // forbid basic-auth
                    $req->username = null;
                    $req->password = null;
                    return;
                }
                break;
        }
    }

    // どうしようもない失敗なのか、リトライする余地があるのかを判別する
    public function after(HttpGetResponse $res)
    {
        if (CURLE_OK !== $res->errno) {
            throw new Downloader\TransportException("$res->error:$res->errno");
        }

        switch ($res->info['http_code']) {
            case 200: //OK
                return;
            case 401: //Unauthorized
            case 403: //Forbidden
            case 404: //Not Found
                $res->setNeedAuth();
                break;
            case 407: //Proxy Authentication Required
                break;
        }
    }
}


1		<?php
2		/*
3		* hirak/prestissimo
4		* @author Hiraku NAKANO
5		* @license MIT https://github.com/hirak/prestissimo
6		*/
7		namespace Hirak\Prestissimo\Aspects;
8
9		use SplObserver;
10		use SplSubject;
11		use Composer\Downloader;
12
13		/**
14		* Authentication aspects.
15		*/
16		class AspectAuth implements SplObserver
17		{
18	2	public function update(SplSubject $ev)
19		{
20	2	switch ((string)$ev) {
21	2	case 'pre-download':
22	2	$this->before($ev->refRequest());
23	2	break;
24	2	case 'post-download':
25	2	$this->after($ev->refResponse());
26	2	break;
27		}
28	2	}
29
30	2	public function before(HttpGetRequest $req)
31		{
32	2	if (!$req->username \|\| !$req->password) {
33	2	$req->username = null;
34	2	$req->password = null;
35	2	return;
36		}
37
38		switch ($req->special) {
39		case 'github':
40		if ($req->password === 'x-oauth-basic') {
41		$req->query['access_token'] = $req->username;
42		// forbid basic-auth
43		$req->username = null;
44		$req->password = null;
45		return;
46		}
47		break;
48		case 'gitlab':
49		if ($req->password === 'oauth2') {
50		$req->headers[] = 'Authorization: Bearer ' . $req->username;
51		// forbid basic-auth
52		$req->username = null;
53		$req->password = null;
54		return;
55		}
56		break;
57		}
58		}
59
60		// どうしようもない失敗なのか、リトライする余地があるのかを判別する
61	2	public function after(HttpGetResponse $res)
62		{
63	2	if (CURLE_OK !== $res->errno) {
64		throw new Downloader\TransportException("$res->error:$res->errno");
65		}
66
67	2	switch ($res->info['http_code']) {
68	2	case 200: //OK
69	2	return;
70		case 401: //Unauthorized
71		case 403: //Forbidden
72		case 404: //Not Found
73		$res->setNeedAuth();
74		break;
75		case 407: //Proxy Authentication Required
76		break;
77		}
78		}
79		}
80

hirak / prestissimo

Pull Request — master (#31)

AspectAuth::after() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like