AspectAuth::after() - Code Metrics - Inspection of "(WIP)Improve scrutinizer score" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#44)

by Hiraku

created 2016-02-06 13:41 UTC

AspectAuth::after() B

↳ Parent: AspectAuth

Complexity

Conditions	7
Paths	7

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	16.7246

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	18
ccs	5
cts	12
cp	0.4167
rs	8.2222
cc	7
eloc	13
nc	7
nop	1
crap	16.7246

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo\Aspects;

use SplObserver;
use SplSubject;
use Composer\Downloader;

/**
 * Authentication aspects.
 */
class AspectAuth implements SplObserver
{
    public function update(SplSubject $ev)
    {
        switch ((string)$ev) {
            case 'pre-download':
                $this->before($ev->refRequest());
                break;
            case 'post-download':
                $this->after($ev->refResponse());
                break;
        }
    }

    public function before(HttpGetRequest $req)
    {
        if (!$req->username || !$req->password) {
            $req->username = $req->password = null;
            return;
        }

        if ($req instanceof GitHubRequest && $req->password === 'x-oauth-basic') {
            $req->query['access_token'] = $req->username;
            // forbid basic-auth
            $req->username = $req->password = null;
            return;
        }

        if ($req instanceof GitLabRequest && $req->password === 'oauth2') {
            $req->headers[] = 'Authorization: Bearer ' . $req->username;
            // forbid basic-auth
            $req->username = $req->password = null;
            return;
        }
    }

    public function after(HttpGetResponse $res)
    {
        if (CURLE_OK !== $res->errno) {
            throw new Downloader\TransportException("$res->error:$res->errno");
        }

        switch ($res->info['http_code']) {
            case 200: //OK
                return;
            case 401: //Unauthorized
            case 403: //Forbidden
            case 404: //Not Found
                $res->setNeedAuth();
                break;
            case 407: //Proxy Authentication Required
                break;
        }
    }
}


1		<?php
2		/*
3		* hirak/prestissimo
4		* @author Hiraku NAKANO
5		* @license MIT https://github.com/hirak/prestissimo
6		*/
7		namespace Hirak\Prestissimo\Aspects;
8
9		use SplObserver;
10		use SplSubject;
11		use Composer\Downloader;
12
13		/**
14		* Authentication aspects.
15		*/
16		class AspectAuth implements SplObserver
17		{
18	5	public function update(SplSubject $ev)
19		{
20	5	switch ((string)$ev) {
21	5	case 'pre-download':
22	5	$this->before($ev->refRequest());
23	5	break;
24	5	case 'post-download':
25	5	$this->after($ev->refResponse());
26	5	break;
27		}
28	5	}
29
30	5	public function before(HttpGetRequest $req)
31		{
32	5	if (!$req->username \|\| !$req->password) {
33	5	$req->username = $req->password = null;
34	5	return;
35	5	}
36
37		if ($req instanceof GitHubRequest && $req->password === 'x-oauth-basic') {
38		$req->query['access_token'] = $req->username;
39		// forbid basic-auth
40		$req->username = $req->password = null;
41		return;
42		}
43
44		if ($req instanceof GitLabRequest && $req->password === 'oauth2') {
45		$req->headers[] = 'Authorization: Bearer ' . $req->username;
46		// forbid basic-auth
47		$req->username = $req->password = null;
48		return;
49		}
50		}
51
52		public function after(HttpGetResponse $res)
53		{
54		if (CURLE_OK !== $res->errno) {
55		throw new Downloader\TransportException("$res->error:$res->errno");
56		}
57
58		switch ($res->info['http_code']) {
59		case 200: //OK
60		return;
61	5	case 401: //Unauthorized
62		case 403: //Forbidden
63	5	case 404: //Not Found
64		$res->setNeedAuth();
65		break;
66		case 407: //Proxy Authentication Required
67	5	break;
68	5	}
69	2	}
70		}
71

hirak / prestissimo

Pull Request — master (#44)

AspectAuth::after() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like