Complex classes like HttpGetRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HttpGetRequest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
17 | class HttpGetRequest |
||
18 | { |
||
19 | public $origin; |
||
20 | public $scheme = 'http'; |
||
21 | public $host = 'example.com'; |
||
22 | public $port = 80; |
||
23 | public $path = '/'; |
||
24 | |||
25 | public $query = array(); |
||
26 | public $headers = array(); |
||
27 | |||
28 | public $curlOpts = array(); |
||
29 | |||
30 | public $username = null; |
||
31 | public $password = null; |
||
32 | |||
33 | public $maybePublic = false; |
||
34 | public $verbose = false; |
||
35 | |||
36 | /** @var CConfig */ |
||
37 | protected $config; |
||
38 | |||
39 | /** @internal */ |
||
40 | const TOKEN_LABEL = 'access_token'; |
||
41 | |||
42 | /** |
||
43 | * normalize url and authentication info |
||
44 | * @param string $origin domain text |
||
45 | * @param string $url |
||
46 | * @param IO\IOInterface $io |
||
47 | */ |
||
48 | 26 | public function __construct($origin, $url, IO\IOInterface $io) |
|
49 | { |
||
50 | 26 | $this->origin = $origin; |
|
51 | 26 | $this->importURL($url); |
|
52 | |||
53 | 26 | if ($this->username && $this->password) { |
|
54 | 3 | $io->setAuthentication($origin, $this->username, $this->password); |
|
55 | 26 | } elseif ($io->hasAuthentication($origin)) { |
|
56 | 2 | $auth = $io->getAuthentication($origin); |
|
57 | 2 | $this->username = $auth['username']; |
|
58 | 2 | $this->password = $auth['password']; |
|
59 | 2 | } |
|
60 | 26 | } |
|
61 | |||
62 | /** |
||
63 | * @param string $url |
||
64 | */ |
||
65 | 26 | public function importURL($url) |
|
66 | { |
||
67 | 26 | $struct = parse_url($url); |
|
68 | // @codeCoverageIgnoreStart |
||
69 | if (!$struct) { |
||
70 | throw new \InvalidArgumentException("$url is not valid URL"); |
||
71 | } |
||
72 | // @codeCoverageIgnoreEnd |
||
73 | |||
74 | 26 | $this->scheme = self::setOr($struct, 'scheme'); |
|
75 | 26 | $this->host = self::setOr($struct, 'host'); |
|
76 | 26 | $this->port = self::setOr($struct, 'port'); |
|
77 | 26 | $this->path = self::setOr($struct, 'path'); |
|
78 | 26 | $this->username = self::setOr($struct, 'user'); |
|
79 | 26 | $this->password = self::setOr($struct, 'pass'); |
|
80 | |||
81 | 26 | if (!empty($struct['query'])) { |
|
82 | 3 | parse_str($struct['query'], $this->query); |
|
83 | 3 | } |
|
84 | 26 | } |
|
85 | |||
86 | |||
87 | /** |
||
88 | * @param array $struct |
||
89 | * @param string $key |
||
90 | * @param string $default |
||
91 | * @return mixed |
||
92 | */ |
||
93 | 26 | private static function setOr(array $struct, $key, $default = null) |
|
101 | |||
102 | /** |
||
103 | * process option for RemortFileSystem |
||
104 | * @param array $options |
||
105 | * @return void |
||
106 | */ |
||
107 | 2 | public function processRFSOption(array $options) |
|
113 | |||
114 | /** |
||
115 | * @return array |
||
116 | */ |
||
117 | 4 | public function getCurlOpts() |
|
118 | { |
||
119 | 4 | $headers = $this->headers; |
|
120 | 4 | if ($this->username && $this->password) { |
|
121 | 1 | foreach ($headers as $i => $header) { |
|
122 | if (0 === strpos($header, 'Authorization:')) { |
||
123 | unset($headers[$i]); |
||
124 | } |
||
125 | 1 | } |
|
126 | 1 | $headers[] = 'Authorization: Basic ' . base64_encode("$this->username:$this->password"); |
|
127 | 1 | } |
|
128 | |||
129 | 4 | $curlOpts = $this->curlOpts + array( |
|
130 | 4 | CURLOPT_HTTPGET => true, |
|
131 | 4 | CURLOPT_FOLLOWLOCATION => true, |
|
132 | 4 | CURLOPT_MAXREDIRS => 20, |
|
133 | 4 | CURLOPT_ENCODING => 'gzip', |
|
134 | 4 | CURLOPT_HTTPHEADER => $headers, |
|
135 | 4 | CURLOPT_USERAGENT => $this->genUA(), |
|
136 | 4 | CURLOPT_VERBOSE => (bool)$this->verbose, |
|
137 | 4 | CURLOPT_URL => $this->getUrl(), |
|
138 | 4 | ); |
|
139 | 4 | unset($curlOpts[CURLOPT_USERPWD]); |
|
140 | |||
141 | 4 | if ($ciphers = $this->nssCiphers()) { |
|
142 | $curlOpts[CURLOPT_SSL_CIPHER_LIST] = $ciphers; |
||
143 | } |
||
144 | |||
145 | 4 | return $curlOpts; |
|
146 | } |
||
147 | |||
148 | /** |
||
149 | * enable ECC cipher suites in cURL/NSS |
||
150 | */ |
||
151 | 4 | public function nssCiphers() |
|
152 | { |
||
153 | 4 | static $cache; |
|
154 | 4 | if (isset($cache)) { |
|
155 | 3 | return $cache; |
|
156 | } |
||
157 | 2 | $ver = curl_version(); |
|
158 | 2 | if (preg_match('/^NSS.*Basic ECC$/', $ver['ssl_version'])) { |
|
159 | $ciphers = array(); |
||
160 | foreach (new \SplFileObject(__DIR__ . '/../../res/nss_ciphers.txt') as $line) { |
||
161 | $line = trim($line); |
||
162 | if ($line) { |
||
163 | $ciphers[] = $line; |
||
164 | } |
||
165 | } |
||
166 | return $cache = implode(',', $ciphers); |
||
167 | } |
||
168 | 2 | return $cache = false; |
|
169 | } |
||
170 | |||
171 | 12 | public function getURL() |
|
172 | { |
||
173 | 12 | $url = ''; |
|
174 | 12 | if ($this->scheme) { |
|
175 | 12 | $url .= "$this->scheme://"; |
|
176 | 12 | } |
|
177 | 12 | $url .= $this->host; |
|
178 | |||
179 | 12 | if ($this->port) { |
|
180 | 3 | $url .= ":$this->port"; |
|
181 | 3 | } |
|
182 | |||
183 | 12 | $url .= $this->path; |
|
184 | |||
185 | 12 | if ($this->query) { |
|
|
|||
186 | 3 | $url .= '?' . http_build_query($this->query); |
|
187 | 3 | } |
|
188 | |||
189 | 12 | return $url; |
|
190 | } |
||
191 | |||
192 | 2 | public function setConfig(CConfig $config) |
|
196 | |||
197 | 3 | public function promptAuth(HttpGetResponse $res, IO\IOInterface $io) |
|
198 | { |
||
199 | 3 | $httpCode = $res->info['http_code']; |
|
200 | // 404s are only handled for github |
||
201 | 3 | if (404 === $httpCode) { |
|
202 | return false; |
||
203 | } |
||
204 | |||
205 | // fail if the console is not interactive |
||
206 | 3 | if (!$io->isInteractive() && ($httpCode === 401 || $httpCode === 403)) { |
|
207 | 1 | $message = "The '{$this->getURL()}' URL required authentication.\nYou must be using the interactive console to authenticate"; |
|
208 | 1 | throw new Downloader\TransportException($message, $httpCode); |
|
209 | } |
||
210 | |||
211 | // fail if we already have auth |
||
212 | 2 | if ($io->hasAuthentication($this->origin)) { |
|
213 | 1 | throw new Downloader\TransportException("Invalid credentials for '{$this->getURL()}', aborting.", $httpCode); |
|
214 | } |
||
215 | |||
216 | 1 | $io->overwrite(" Authentication required (<info>$this->host</info>):"); |
|
217 | 1 | $username = $io->ask(' Username: '); |
|
218 | 1 | $password = $io->askAndHideAnswer(' Password: '); |
|
219 | 1 | $io->setAuthentication($this->origin, $username, $password); |
|
220 | 1 | return true; |
|
221 | } |
||
222 | |||
223 | /** |
||
224 | * @internal |
||
225 | * @param int $privateCode 404|403 |
||
226 | * @param Composer\Util\GitHub|Composer\Util\GitLab $util |
||
227 | * @param HttpGetResponse $res |
||
228 | * @param IO\IOInterface $io |
||
229 | * @throws Composer\Downloader\TransportException |
||
230 | * @return bool |
||
231 | */ |
||
232 | 2 | public function promptAuthWithUtil($privateCode, $util, HttpGetResponse $res, IO\IOInterface $io) |
|
251 | |||
252 | /** |
||
253 | * @return string |
||
254 | */ |
||
255 | 4 | public static function genUA() |
|
271 | } |
||
272 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)
or! empty(...)
instead.