AspectAuth::before() - Code Metrics - Inspection of "(WIP)Improve scrutinizer score" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#44)

by Hiraku

created 2016-02-07 02:16 UTC

AspectAuth::before() B

↳ Parent: AspectAuth

Complexity

Conditions	7
Paths	4

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	7

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	21
ccs	13
cts	13
cp	1
rs	7.551
cc	7
eloc	12
nc	4
nop	1
crap	7

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo\Aspects;

use SplObserver;
use SplSubject;
use Composer\Downloader;

/**
 * Authentication aspects.
 */
class AspectAuth implements SplObserver
{
    public function update(SplSubject $ev)
    {
        $name = (string)$ev;
        if ('pre-download' === $name) {
            return $this->before($ev->refRequest());
        }
        if ('post-download' === $name) {
            $this->after($ev->refResponse());
        }
    }

    private function before(HttpGetRequest $req)
    {
        if (!$req->username || !$req->password) {
            $req->username = $req->password = null;
            return;
        }

        if ($req instanceof GitHubRequest && $req->password === 'x-oauth-basic') {
            $req->query['access_token'] = $req->username;
            // forbid basic-auth
            $req->username = $req->password = null;
            return;
        }

        if ($req instanceof GitLabRequest && $req->password === 'oauth2') {
            $req->headers[] = 'Authorization: Bearer ' . $req->username;
            // forbid basic-auth
            $req->username = $req->password = null;
            return;
        }
    }

    private function after(HttpGetResponse $res)
    {
        if (CURLE_OK !== $res->errno) {
            throw new Downloader\TransportException("$res->error:$res->errno");
        }

        if (in_array($res->info['http_code'], array(401, 403, 404))) {
            $res->setNeedAuth();
            return;
        }
    }
}


1		<?php
2		/*
3		* hirak/prestissimo
4		* @author Hiraku NAKANO
5		* @license MIT https://github.com/hirak/prestissimo
6		*/
7		namespace Hirak\Prestissimo\Aspects;
8
9		use SplObserver;
10		use SplSubject;
11		use Composer\Downloader;
12
13		/**
14		* Authentication aspects.
15		*/
16		class AspectAuth implements SplObserver
17		{
18	10	public function update(SplSubject $ev)
19		{
20	10	$name = (string)$ev;
21	10	if ('pre-download' === $name) {
22	8	return $this->before($ev->refRequest());
23		}
24	7	if ('post-download' === $name) {
25	7	$this->after($ev->refResponse());
26	6	}
27	6	}
28
29	8	private function before(HttpGetRequest $req)
30		{
31	8	if (!$req->username \|\| !$req->password) {
32	6	$req->username = $req->password = null;
33	6	return;
34		}
35
36	3	if ($req instanceof GitHubRequest && $req->password === 'x-oauth-basic') {
37	1	$req->query['access_token'] = $req->username;
38		// forbid basic-auth
39	1	$req->username = $req->password = null;
40	1	return;
41		}
42
43	2	if ($req instanceof GitLabRequest && $req->password === 'oauth2') {
44	1	$req->headers[] = 'Authorization: Bearer ' . $req->username;
45		// forbid basic-auth
46	1	$req->username = $req->password = null;
47	1	return;
48		}
49	1	}
50
51	7	private function after(HttpGetResponse $res)
52		{
53	7	if (CURLE_OK !== $res->errno) {
54	1	throw new Downloader\TransportException("$res->error:$res->errno");
55		}
56
57	6	if (in_array($res->info['http_code'], array(401, 403, 404))) {
58	4	$res->setNeedAuth();
59	4	return;
60		}
61	3	}
62		}
63

hirak / prestissimo

Pull Request — master (#44)

AspectAuth::before() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like