Hirak\Prestissimo\CurlRemoteFilesystem

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	14
Bugs	4	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getContents()	0	15	3
A	getLastHeaders()	0	8	3
A	__debugInfo()	0	4	1

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo;

use Composer\Config;
use Composer\IO;
use Composer\Downloader;
use Composer\Util;

class CurlRemoteFilesystem extends Util\RemoteFilesystem
{
    protected $io, $config, $options, $disableTls;

It is generally advisable to only define one property per statement.

    private $req;

    /**
     * @inheritDoc
     */
    public function __construct(IO\IOInterface $io, Config $config = null, array $options = array(), $disableTls = false)
    {
        $this->io = $io;
        $this->config = $config;
        $this->options = $options;
        $this->disableTls = $disableTls;
        parent::__construct($io, $config, $options, $disableTls);
    }

    /**
     * @inheritDoc
     */
    public function getContents($originUrl, $fileUrl, $progress = true, $options = array())
    {
        $res = null;
        try {
            $this->req = new FetchRequest($fileUrl, $this->io, $this->config);

It seems like $this->config can be null; however, __construct() does not accept null, maybe add an additional type check?

            $res = $this->req->fetch();
        } catch (\Exception $e) {
            $this->io->writeError((string)$e);
        }
        if ($res) {
            return $res;
        } else {
            return parent::getContents($originUrl, $fileUrl, $progress, $options);
        }
    }

    public function getLastHeaders()
    {
        if ($this->req && ($headers = $this->req->getLastHeaders())) {
            return $headers;
        } else {
            return parent::getLastHeaders();
        }
    }

    public function __debugInfo()
    {
        return array();
    }
}