CurlRemoteFilesystem::getContents() - Code Metrics - Inspection of "Improve test coverage" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#111)

by Hiraku

created 2016-06-26 07:46 UTC

CurlRemoteFilesystem::getContents() A

↳ Parent: CurlRemoteFilesystem

Complexity

Conditions	3
Paths	6

Size

Total Lines	15
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3.0987

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	15
ccs	7
cts	9
cp	0.7778
rs	9.4285
cc	3
eloc	11
nc	6
nop	4
crap	3.0987

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo;

use Composer\Config;
use Composer\IO;
use Composer\Util;

class CurlRemoteFilesystem extends Util\RemoteFilesystem
{
    protected $io;
    protected $config;
    protected $options;
    protected $disableTls;

    private $req;

    /**
     * @inheritDoc
     */
    public function __construct(IO\IOInterface $io, Config $config = null, array $options = array(), $disableTls = false)
    {
        $this->io = $io;
        $this->config = $config;
        $this->options = $options;
        $this->disableTls = $disableTls;
        parent::__construct($io, $config, $options, $disableTls);
    }

    /**
     * @inheritDoc
     */
    public function getContents($originUrl, $fileUrl, $progress = true, $options = array())
    {
        $res = null;
        try {
            $this->req = new FetchRequest($fileUrl, $this->io, $this->config);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $res = $this->req->fetch();
        } catch (\Exception $e) {
            $this->io->writeError((string)$e);
        }
        if ($res) {
            return $res;
        } else {
            return parent::getContents($originUrl, $fileUrl, $progress, $options);
        }
    }

    public function getLastHeaders()
    {
        if ($this->req && ($headers = $this->req->getLastHeaders())) {
            return $headers;
        } else {
            return parent::getLastHeaders();
        }
    }

    public function __debugInfo()
    {
        return array();
    }
}


1		<?php
2		/*
3		* hirak/prestissimo
4		* @author Hiraku NAKANO
5		* @license MIT https://github.com/hirak/prestissimo
6		*/
7		namespace Hirak\Prestissimo;
8
9		use Composer\Config;
10		use Composer\IO;
11		use Composer\Util;
12
13		class CurlRemoteFilesystem extends Util\RemoteFilesystem
14		{
15		protected $io;
16		protected $config;
17		protected $options;
18		protected $disableTls;
19
20		private $req;
21
22		/**
23		* @inheritDoc
24		*/
25	1	public function __construct(IO\IOInterface $io, Config $config = null, array $options = array(), $disableTls = false)
26		{
27	1	$this->io = $io;
28	1	$this->config = $config;
29	1	$this->options = $options;
30	1	$this->disableTls = $disableTls;
31	1	parent::__construct($io, $config, $options, $disableTls);
32	1	}
33
34		/**
35		* @inheritDoc
36		*/
37	1	public function getContents($originUrl, $fileUrl, $progress = true, $options = array())
38		{
39	1	$res = null;
40		try {
41	1	$this->req = new FetchRequest($fileUrl, $this->io, $this->config);
		0 ignored issues – show Bug introduced 2016-06-05 14:07 UTC by Report Bug Copy Issue Report It seems like `$this->config` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
42	1	$res = $this->req->fetch();
43	1	} catch (\Exception $e) {
44		$this->io->writeError((string)$e);
45		}
46	1	if ($res) {
47		return $res;
48		} else {
49	1	return parent::getContents($originUrl, $fileUrl, $progress, $options);
50		}
51		}
52
53	1	public function getLastHeaders()
54		{
55	1	if ($this->req && ($headers = $this->req->getLastHeaders())) {
56		return $headers;
57		} else {
58	1	return parent::getLastHeaders();
59		}
60		}
61
62	1	public function __debugInfo()
63		{
64	1	return array();
65		}
66		}
67

hirak / prestissimo

Pull Request — master (#111)

CurlRemoteFilesystem::getContents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like