CurlRemoteFilesystem - Code Metrics - Inspection of "Improve test coverage" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#111)

by Hiraku

created 2016-06-26 07:46 UTC

CurlRemoteFilesystem A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

86.36%

Importance

Changes	11
Bugs	2	Features	0

Metric	Value
wmc	8
c	11
b	2
f	0
lcom	1
cbo	3
dl	0
loc	54
ccs	19
cts	22
cp	0.8636
rs	10

4 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	getContents()	15	3
A	getLastHeaders()	8	3
A	__debugInfo()	4	1

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo;

use Composer\Config;
use Composer\IO;
use Composer\Util;

class CurlRemoteFilesystem extends Util\RemoteFilesystem
{
    protected $io;
    protected $config;
    protected $options;
    protected $disableTls;

    private $req;

    /**
     * @inheritDoc
     */
    public function __construct(IO\IOInterface $io, Config $config = null, array $options = array(), $disableTls = false)
    {
        $this->io = $io;
        $this->config = $config;
        $this->options = $options;
        $this->disableTls = $disableTls;
        parent::__construct($io, $config, $options, $disableTls);
    }

    /**
     * @inheritDoc
     */
    public function getContents($originUrl, $fileUrl, $progress = true, $options = array())
    {
        $res = null;
        try {
            $this->req = new FetchRequest($fileUrl, $this->io, $this->config);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $res = $this->req->fetch();
        } catch (\Exception $e) {
            $this->io->writeError((string)$e);
        }
        if ($res) {
            return $res;
        } else {
            return parent::getContents($originUrl, $fileUrl, $progress, $options);
        }
    }

    public function getLastHeaders()
    {
        if ($this->req && ($headers = $this->req->getLastHeaders())) {
            return $headers;
        } else {
            return parent::getLastHeaders();
        }
    }

    public function __debugInfo()
    {
        return array();
    }
}


1		<?php
2		/*
3		* hirak/prestissimo
4		* @author Hiraku NAKANO
5		* @license MIT https://github.com/hirak/prestissimo
6		*/
7		namespace Hirak\Prestissimo;
8
9		use Composer\Config;
10		use Composer\IO;
11		use Composer\Util;
12
13		class CurlRemoteFilesystem extends Util\RemoteFilesystem
14		{
15		protected $io;
16		protected $config;
17		protected $options;
18		protected $disableTls;
19
20		private $req;
21
22		/**
23		* @inheritDoc
24		*/
25	1	public function __construct(IO\IOInterface $io, Config $config = null, array $options = array(), $disableTls = false)
26		{
27	1	$this->io = $io;
28	1	$this->config = $config;
29	1	$this->options = $options;
30	1	$this->disableTls = $disableTls;
31	1	parent::__construct($io, $config, $options, $disableTls);
32	1	}
33
34		/**
35		* @inheritDoc
36		*/
37	1	public function getContents($originUrl, $fileUrl, $progress = true, $options = array())
38		{
39	1	$res = null;
40		try {
41	1	$this->req = new FetchRequest($fileUrl, $this->io, $this->config);
		0 ignored issues – show Bug introduced 2016-06-05 14:07 UTC by Report Bug Copy Issue Report It seems like `$this->config` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
42	1	$res = $this->req->fetch();
43	1	} catch (\Exception $e) {
44		$this->io->writeError((string)$e);
45		}
46	1	if ($res) {
47		return $res;
48		} else {
49	1	return parent::getContents($originUrl, $fileUrl, $progress, $options);
50		}
51		}
52
53	1	public function getLastHeaders()
54		{
55	1	if ($this->req && ($headers = $this->req->getLastHeaders())) {
56		return $headers;
57		} else {
58	1	return parent::getLastHeaders();
59		}
60		}
61
62	1	public function __debugInfo()
63		{
64	1	return array();
65		}
66		}
67

hirak / prestissimo

Pull Request — master (#111)

CurlRemoteFilesystem A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like