Completed
Pull Request — master (#176)
by Markus
01:36
created

FetchRequest   A

Complexity

Total Complexity 19

Size/Duplication

Total Lines 106
Duplicated Lines 10.38 %

Coupling/Cohesion

Components 2
Dependencies 3

Test Coverage

Coverage 77.08%

Importance

Changes 0
Metric Value
wmc 19
lcom 2
cbo 3
dl 11
loc 106
ccs 37
cts 48
cp 0.7708
rs 10
c 0
b 0
f 0

7 Methods

Rating   Name   Duplication   Size   Complexity  
A getCurlOptions() 0 7 1
A getCurl() 0 13 2
A __construct() 11 11 3
A getLastError() 0 8 3
A getLastHeaders() 0 4 1
A headerCallback() 0 6 1
B fetch() 0 28 8

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/*
3
 * hirak/prestissimo
4
 * @author Hiraku NAKANO
5
 * @license MIT https://github.com/hirak/prestissimo
6
 */
7
namespace Hirak\Prestissimo;
8
9
use Composer\IO;
10
use Composer\Config;
11
12
class FetchRequest extends BaseRequest
13
{
14
    protected static $defaultCurlOptions = array(
15
        CURLOPT_HTTPGET => true,
16
        CURLOPT_FOLLOWLOCATION => true,
17
        CURLOPT_MAXREDIRS => 20,
18
        CURLOPT_ENCODING => '',
19
        CURLOPT_RETURNTRANSFER => true,
20
    );
21
22
    private $headers = array();
0 ignored issues
show
Comprehensibility introduced by
Consider using a different property name as you override a private property of the parent class.
Loading history...
23
    private $errno;
24
    private $error;
25
26
    /**
27
     * @param string $url
28
     * @param IO\IOInterface $io
29
     * @param Config $config
30
     */
31 1 View Code Duplication
    public function __construct($url, IO\IOInterface $io, Config $config)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
32
    {
33 1
        $this->setURL($url);
34 1
        $this->setCA($config->get('capath'), $config->get('cafile'));
35 1
        $this->setupAuthentication(
36 1
            $io,
37 1
            false,
38 1
            $config->get('github-domains') ?: array(),
39 1
            $config->get('gitlab-domains') ?: array()
40
        );
41 1
    }
42
43 1
    public function getCurlOptions()
44
    {
45 1
        $curlOpts = parent::getCurlOptions();
46 1
        $curlOpts[CURLOPT_RETURNTRANSFER] = true;
47 1
        $curlOpts[CURLOPT_HEADERFUNCTION] = array($this, 'headerCallback');
48 1
        return $curlOpts;
49
    }
50
51 1
    private static function getCurl($key)
52
    {
53 1
        static $curlCache = array();
54
55 1
        if (isset($curlCache[$key])) {
56
            return $curlCache[$key];
57
        }
58
59 1
        $ch = curl_init();
60 1
        Share::setup($ch);
61
62 1
        return $curlCache[$key] = $ch;
63
    }
64
65
    /**
66
     * @return string|false
67
     */
68 1
    public function fetch()
69
    {
70 1
        $url = $this->getOriginURL();
71 1
        $ch = self::getCurl($url);
72 1
        curl_setopt_array($ch, $this->getCurlOptions());
73
74
        // feature detect http2 support in the php client/curl version.
75 1
        if (0 === stripos($url, 'https://') && defined('CURL_VERSION_HTTP2') && defined('CURL_HTTP_VERSION_2_0')) {
76 1
            $curlVersion = curl_version();
77 1
            if ($curlVersion["features"] & CURL_VERSION_HTTP2 !== 0) {
78 1
                curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);
79
            }
80
        }
81
82 1
        $result = curl_exec($ch);
83
84 1
        $this->errno = $errno = curl_errno($ch);
85 1
        $this->error = curl_error($ch);
86 1
        $info = curl_getinfo($ch);
87
88 1
        if (!$this->isHTTP()) {
89
            return $result;
90 1
        } elseif ($errno === CURLE_OK && in_array($info['http_code'], array(200, 304))) {
91
            return $result;
92
        } else {
93 1
            return false;
94
        }
95
    }
96
97
    public function getLastError()
98
    {
99
        if ($this->errno || $this->error) {
100
            return array($this->errno, $this->error);
101
        } else {
102
            return array();
103
        }
104
    }
105
106 1
    public function getLastHeaders()
107
    {
108 1
        return $this->headers;
109
    }
110
111
    public function headerCallback($ch, $headerString)
112
    {
113
        $len = strlen($headerString);
114
        $this->headers[] = $headerString;
115
        return $len;
116
    }
117
}
118