GitHubRequest::promptAuth() - Code Metrics - Inspection of "(WIP)Implove scrutinizer score 6" - hirak/prestissimo - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#68)

by Hiraku

created 2016-03-13 01:05 UTC

GitHubRequest::promptAuth() A

↳ Parent: GitHubRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	5
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	1.0156

Importance

Changes	5
Bugs	0	Features	1

Metric	Value
c	5
b	0
f	1
dl	5
loc	5
ccs	3
cts	4
cp	0.75
rs	9.4285
cc	1
eloc	3
nc	1
nop	2
crap	1.0156

<?php
/*
 * hirak/prestissimo
 * @author Hiraku NAKANO
 * @license MIT https://github.com/hirak/prestissimo
 */
namespace Hirak\Prestissimo\Aspects;

use Composer\IO;

/**
 * Simple Container for http-get request
 * GitHub edition
 */
class GitHubRequest extends HttpGetRequest

{
    const TOKEN_LABEL = 'github-token';

    public function __construct($origin, $url, IO\IOInterface $io)
    {
        parent::__construct($origin, $url, $io);
        if ($this->password === 'x-oauth-basic') {
            $this->query['access_token'] = $this->username;
            // forbid basic-auth
            $this->username = $this->password = null;
        }
    }

    public function promptAuth(HttpGetResponse $res, IO\IOInterface $io)
    {
        $util = new \Composer\Util\GitHub($io, $this->config, null);
        $this->promptAuthWithUtil(404, $util, $res, $io);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			/*
3			* hirak/prestissimo
4			* @author Hiraku NAKANO
5			* @license MIT https://github.com/hirak/prestissimo
6			*/
7			namespace Hirak\Prestissimo\Aspects;
8
9			use Composer\IO;
10
11			/**
12			* Simple Container for http-get request
13			* GitHub edition
14			*/
15		View Code Duplication	class GitHubRequest extends HttpGetRequest
			0 ignored issues – show Duplication introduced 2016-02-06 12:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16			{
17			const TOKEN_LABEL = 'github-token';
18
19	5		public function __construct($origin, $url, IO\IOInterface $io)
20			{
21	5		parent::__construct($origin, $url, $io);
22	5		if ($this->password === 'x-oauth-basic') {
23	1		$this->query['access_token'] = $this->username;
24			// forbid basic-auth
25	1		$this->username = $this->password = null;
26	1		}
27	5		}
28
29	1		public function promptAuth(HttpGetResponse $res, IO\IOInterface $io)
30			{
31	1		$util = new \Composer\Util\GitHub($io, $this->config, null);
32	1		$this->promptAuthWithUtil(404, $util, $res, $io);
			0 ignored issues – show Documentation introduced 2016-03-13 01:08 UTC by Report Bug Copy Issue Report `$util` is of type `object<Composer\Util\GitHub>`, but the function expects a `object<Composer\Composer...r\Composer\Util\GitLab>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			}
34			}
35

hirak / prestissimo

Pull Request — master (#68)

GitHubRequest::promptAuth() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like