Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | class FetchRequest extends BaseRequest |
||
| 13 | { |
||
| 14 | protected static $defaultCurlOptions = array( |
||
| 15 | CURLOPT_HTTPGET => true, |
||
| 16 | CURLOPT_FOLLOWLOCATION => true, |
||
| 17 | CURLOPT_MAXREDIRS => 20, |
||
| 18 | CURLOPT_ENCODING => '', |
||
| 19 | CURLOPT_RETURNTRANSFER => true, |
||
| 20 | ); |
||
| 21 | |||
| 22 | private $headers = array(); |
||
|
|
|||
| 23 | private $errno; |
||
| 24 | private $error; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @param string $url |
||
| 28 | * @param IO\IOInterface $io |
||
| 29 | * @param Config $config |
||
| 30 | */ |
||
| 31 | 1 | View Code Duplication | public function __construct($url, IO\IOInterface $io, Config $config) |
| 32 | { |
||
| 33 | 1 | $this->setURL($url); |
|
| 34 | 1 | $this->setCA($config->get('capath'), $config->get('cafile')); |
|
| 35 | 1 | $this->setupAuthentication( |
|
| 36 | 1 | $io, |
|
| 37 | 1 | false, |
|
| 38 | 1 | $config->get('github-domains') ?: array(), |
|
| 39 | 1 | $config->get('gitlab-domains') ?: array() |
|
| 40 | ); |
||
| 41 | 1 | } |
|
| 42 | |||
| 43 | 1 | public function getCurlOptions() |
|
| 50 | |||
| 51 | 1 | private static function getCurl($key) |
|
| 64 | |||
| 65 | /** |
||
| 66 | * @return string|false |
||
| 67 | */ |
||
| 68 | 1 | public function fetch() |
|
| 87 | |||
| 88 | public function getLastError() |
||
| 96 | |||
| 97 | 1 | public function getLastHeaders() |
|
| 101 | |||
| 102 | 1 | public function headerCallback($ch, $headerString) |
|
| 108 | } |
||
| 109 |