View GitHub Repository yii2-theme-obaju

Schedule Inspection
Subscribe
Completed
Push — master ( 941f20...d554c9 )
by Klochok
13:46
created

src/widgets/views/LogoLink.php (1 issue)

Labels
Severity
Introduced By

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
use yii\helpers\Html;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
print Html::beginTag('a', ['href' => $url]);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
print Html::img($image, $options);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
print Html::beginTag('img', array_merge(['src' => $smallImage], $smallImageOptions));

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
print Html::tag('span', $name, ['class' => 'sr-only']);

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
print Html::endTag('img');

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
print Html::endTag('a');

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
?>

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
It is not recommended to use PHP's closing tag ?> in files other than templates.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Using a closing tag in PHP files that only contain PHP code is not recommended
as you might accidentally add whitespace after the closing tag which would then
be output by PHP. This can cause severe problems, for example headers cannot be
sent anymore.


A simple precaution is to leave off the closing tag as it is not required, and
it also has no negative effects whatsoever.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    13