Flashes   A
last analyzed

Complexity

Total Complexity 7

Size/Duplication

Total Lines 61
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 4

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 7
lcom 1
cbo 4
dl 0
loc 61
ccs 0
cts 27
cp 0
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A normalizeMessage() 0 11 3
A run() 0 23 4
1
<?php
2
/**
3
 * Yii2 adapter for PNotify JQuery extension
4
 *
5
 * @link      https://github.com/hiqdev/yii2-pnotify
6
 * @package   yii2-pnotify
7
 * @license   BSD-3-Clause
8
 * @copyright Copyright (c) 2015-2016, HiQDev (http://hiqdev.com/)
9
 */
10
11
namespace hiqdev\pnotify;
12
13
use Yii;
14
use yii\helpers\ArrayHelper;
15
16
/**
17
 * Flashes widget renders messages from session flashes. All flash messages are displayed
18
 * in the sequence they were assigned using setFlash. You can set message as following:.
19
 *
20
 * ```php
21
 * Yii::$app->getSession()->setFlash('error', 'This is the message');
22
 * Yii::$app->getSession()->setFlash('success', 'This is the message');
23
 * Yii::$app->getSession()->setFlash('info', 'This is the message');
24
 * ```
25
 *
26
 * Multiple messages could be set as follows:
27
 *
28
 * ```php
29
 * Yii::$app->getSession()->setFlash('error', ['Error 1', 'Error 2']);
30
 * ```
31
 */
32
class Flashes extends \yii\bootstrap\Widget
33
{
34
    /**
35
     * @var array the alert types configuration for the flash messages.
36
     * This array is setup as $key => $value, where:
37
     * - $key is the name of the session flash variable
38
     * - $value is the bootstrap alert type (i.e. danger, success, info, warning)
39
     */
40
    public $alertTypes = [
41
        'error' => 'alert-danger',
42
        'danger' => 'alert-danger',
43
        'success' => 'alert-success',
44
        'info' => 'alert-info',
45
        'warning' => 'alert-warning',
46
    ];
47
48
    /**
49
     * @var array the options for rendering the close button tag
50
     */
51
    public $closeButton = [];
52
53
    /**
54
     * @param mixed $message Flash value to be normalized
55
     * @return array
56
     */
57
    public function normalizeMessage($message)
58
    {
59
        $res = [];
60
        if (is_string($message)) {
61
            $res['text'] = $message;
62
        } elseif (is_array($message)) {
63
            $res = $message;
64
        }
65
66
        return $res;
67
    }
68
69
    public function run()
70
    {
71
        $flashes = Yii::$app->getSession()->getAllFlashes();
0 ignored issues
show
Bug introduced by
The method getSession does only exist in yii\web\Application, but not in yii\console\Application.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
72
        $notifications = [];
73
74
        foreach ($flashes as $type => $data) {
75
            if (isset($this->alertTypes[$type])) {
76
                $data = (array) $data;
77
78
                foreach ($data as $message) {
79
                    $message = $this->normalizeMessage($message);
80
                    $notifications[] = ArrayHelper::merge([
81
                        'type' => $type,
82
                    ], $message);
83
                }
84
                Yii::$app->getSession()->removeFlash($type);
85
            }
86
        }
87
88
        echo PNotify::widget([
89
            'notifications' => $notifications,
90
        ]);
91
    }
92
}
93