PagesList::createFromDir() - Code Metrics - Inspection of "Implemented basic functionality of ApiStorage (#1)" - hiqdev/yii2-module-pages - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6b77c2...0b4fa8 )

by Andrii

created 2019-04-25 10:13 UTC

PagesList::createFromDir() A

↳ Parent: PagesList

Complexity

Conditions	4
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	14
cp	0
rs	9.7333
c	0
b	0
f	0
cc	4
nc	3
nop	2
crap	20

<?php
/**
 * Yii2 Pages Module
 *
 * @link      https://github.com/hiqdev/yii2-module-pages
 * @package   yii2-module-pages
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\yii2\modules\pages\models;

use hiqdev\yii2\modules\pages\storage\FileSystemStorage;
use yii\data\ArrayDataProvider;
use yii\helpers\ArrayHelper;

class PagesList
{
    /** @var AbstractPage[]  */
    protected $pages = [];

    /**
     * PagesList constructor.
     * @param AbstractPage[] $pages
     */
    public function __construct(array $pages)
    {
        $this->pages = $pages;
    }

    /**
     * @param string $path
     * @param FileSystemStorage $storage
     * @return PagesList
     * @throws \yii\base\InvalidConfigException
     */
    public static function createFromDir(string $path, FileSystemStorage $storage): PagesList
    {
        $list = $storage->getFileSystem()->listContents($path);
        ArrayHelper::multisort($list, 'basename', SORT_DESC);

        $pages = [];
        foreach ($list as $file) {
            if ($file['type'] !== 'file' || $file['basename'][0] === '.') {
                continue;
            }
            $pages[] = AbstractPage::createFromFile($file['path'], $storage);
        }
        $index = new static($pages, $storage);


        return $index;
    }

    /**
     * @return ArrayDataProvider
     */
    public function getDataProvider(): ArrayDataProvider
    {
        return new ArrayDataProvider([
            'allModels' => $this->pages,
            'pagination' => [
                'pageSize' => 5,
            ]
        ]);
    }
}


1			<?php
2			/**
3			* Yii2 Pages Module
4			*
5			* @link https://github.com/hiqdev/yii2-module-pages
6			* @package yii2-module-pages
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2016-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\yii2\modules\pages\models;
12
13			use hiqdev\yii2\modules\pages\storage\FileSystemStorage;
14			use yii\data\ArrayDataProvider;
15			use yii\helpers\ArrayHelper;
16
17			class PagesList
18			{
19			/** @var AbstractPage[] */
20			protected $pages = [];
21
22			/**
23			* PagesList constructor.
24			* @param AbstractPage[] $pages
25			*/
26			public function __construct(array $pages)
27			{
28			$this->pages = $pages;
29			}
30
31			/**
32			* @param string $path
33			* @param FileSystemStorage $storage
34			* @return PagesList
35			* @throws \yii\base\InvalidConfigException
36			*/
37			public static function createFromDir(string $path, FileSystemStorage $storage): PagesList
38			{
39			$list = $storage->getFileSystem()->listContents($path);
40			ArrayHelper::multisort($list, 'basename', SORT_DESC);
41
42			$pages = [];
43			foreach ($list as $file) {
44			if ($file['type'] !== 'file' \|\| $file['basename'][0] === '.') {
45			continue;
46			}
47			$pages[] = AbstractPage::createFromFile($file['path'], $storage);
48			}
49			$index = new static($pages, $storage);
			0 ignored issues – show Unused Code introduced 2019-04-25 10:07 UTC by Report Bug Copy Issue Report The call to `PagesList::__construct()` has too many arguments starting with `$storage`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
50
51			return $index;
52			}
53
54			/**
55			* @return ArrayDataProvider
56			*/
57			public function getDataProvider(): ArrayDataProvider
58			{
59			return new ArrayDataProvider([
60			'allModels' => $this->pages,
61			'pagination' => [
62			'pageSize' => 5,
63			]
64			]);
65			}
66			}
67

hiqdev / yii2-module-pages

Push — master ( 6b77c2...0b4fa8 )

PagesList::createFromDir() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like