RenderController::actionIndex() - Code Metrics - Inspection of "fixed PhpPage to work" - hiqdev/yii2-module-pages - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 29aa5c...85c009 )

by Andrii

created 2017-02-04 05:27 UTC

RenderController::actionIndex() B

↳ Parent: RenderController

Complexity

Conditions	4
Paths	6

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	14
cp	0
rs	8.6845
c	0
b	0
f	0
cc	4
eloc	13
nc	6
nop	1
crap	20

<?php

namespace hiqdev\yii2\modules\pages\controllers;

use hiqdev\yii2\modules\pages\models\AbstractPage;
use hiqdev\yii2\modules\pages\models\PagesIndex;
use Yii;
use yii\helpers\Html;
use yii\web\NotFoundHttpException;

class RenderController extends \yii\web\Controller
{
    public function getViewPath()
    {
        return Yii::$app->getViewPath();
    }

    /**
     * Index action.
     * @param string $page
     * @return string rendered page
     */
    public function actionIndex($page = null)
    {
        if (!$page) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $page = 'posts';
        }

        $path = $this->module->find($page);

        if ($path === null) {
            throw new NotFoundHttpException(Yii::t('yii', 'Page not found.'));
        }

        $meta = $this->module->getMetadata($path);

        if ($meta['type'] === 'dir') {
            $index = PagesIndex::createFromDir($path);

            return $this->render('@hiqdev/com/views/site/index', ['dataProvider' => $index->getDataProvider()]);
        } else {
            $page = AbstractPage::createFromFile($path);

            return $this->renderPage($page);
        }
    }

    public function renderPage($page, array $params = [])
    {
        if ($page->layout) {
            $this->layout = $page->layout;
        }

        if ($page->title) {
            $this->view->title = Html::encode($page->title);
        }

        $this->view->params = $page->getData();

        return $this->renderContent($page->render($params));
    }

}


1			<?php
2
3			namespace hiqdev\yii2\modules\pages\controllers;
4
5			use hiqdev\yii2\modules\pages\models\AbstractPage;
6			use hiqdev\yii2\modules\pages\models\PagesIndex;
7			use Yii;
8			use yii\helpers\Html;
9			use yii\web\NotFoundHttpException;
10
11			class RenderController extends \yii\web\Controller
12			{
13			public function getViewPath()
14			{
15			return Yii::$app->getViewPath();
16			}
17
18			/**
19			* Index action.
20			* @param string $page
21			* @return string rendered page
22			*/
23			public function actionIndex($page = null)
24			{
25			if (!$page) {
			0 ignored issues – show Bug Best Practice introduced 2016-09-22 16:00 UTC by Report Bug Copy Issue Report The expression `$page` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
26			$page = 'posts';
27			}
28
29			$path = $this->module->find($page);
30
31			if ($path === null) {
32			throw new NotFoundHttpException(Yii::t('yii', 'Page not found.'));
33			}
34
35			$meta = $this->module->getMetadata($path);
36
37			if ($meta['type'] === 'dir') {
38			$index = PagesIndex::createFromDir($path);
39
40			return $this->render('@hiqdev/com/views/site/index', ['dataProvider' => $index->getDataProvider()]);
41			} else {
42			$page = AbstractPage::createFromFile($path);
43
44			return $this->renderPage($page);
45			}
46			}
47
48			public function renderPage($page, array $params = [])
49			{
50			if ($page->layout) {
51			$this->layout = $page->layout;
52			}
53
54			if ($page->title) {
55			$this->view->title = Html::encode($page->title);
56			}
57
58			$this->view->params = $page->getData();
59
60			return $this->renderContent($page->render($params));
61			}
62
63			}
64

hiqdev / yii2-module-pages

Push — master ( 29aa5c...85c009 )

RenderController::actionIndex() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like