hiqdev\yii2\mfa\controllers\TotpController

Complexity

Total Complexity

28

Size/Duplication

Total Lines	182
Duplicated Lines	5.49 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	26	1
A	denyCallback()	0	4	1
C	actionEnable()	10	60	11
B	actionDisable()	0	29	6
A	deferredRedirect()	0	4	1
A	actionToggle()	0	7	2
A	actionCheck()	0	30	4
A	goBack()	0	9	2

<?php
/**
 * Multi-factor authentication for Yii2 projects
 *
 * @link      https://github.com/hiqdev/yii2-mfa
 * @package   yii2-mfa
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2016-2018, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\yii2\mfa\controllers;

use hiqdev\yii2\mfa\base\MfaIdentityInterface;
use hiqdev\yii2\mfa\base\RecoveryCodeCollection;
use hiqdev\yii2\mfa\forms\InputForm;
use Yii;
use yii\filters\AccessControl;

/**
 * TOTP controller.
 * Time-based One Time Password.
 */
class TotpController extends \yii\web\Controller
{
    public function behaviors()
    {
        return array_merge(
            parent::behaviors(),
            [
                'access' => [
                    'class' => AccessControl::class,
                    'denyCallback' => [$this, 'denyCallback'],
                    'rules' => [
                        // ? - guest
                        [
                            'actions' => ['check'],
                            'roles' => ['?'],
                            'allow' => true,
                        ],
                        // @ - authenticated
                        [
                            'actions' => ['enable', 'disable', 'toggle'],
                            'roles' => ['@'],
                            'allow' => true,
                        ],
                    ],
                ],
            ]
        );
    }

    public function denyCallback()
    {
        return $this->goHome();
    }

    public function actionEnable($back = null)
    {
        /** @var MfaIdentityInterface $user */
        $user = Yii::$app->user->identity;
        if ($user->getTotpSecret()) {

This code seems to be duplicated across your project.

            Yii::$app->session->setFlash(
                'error',
                Yii::t('mfa', 'Two-factor authentication is already enabled. Disable first.')
            );

            return empty($back) ? $this->goHome() : $this->deferredRedirect($back);
        }

        $model = new InputForm();
        $secret = $this->module->getTotp()->getSecret();

        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            if ($this->module->getTotp()->verifyCode($secret, $model->code)) {
                $user->setTotpSecret($secret);
                $this->module->getTotp()->setIsVerified(true);
                if ($user->save() && Yii::$app->user->login($user)) {
                    $recovery = new RecoveryCodeCollection();
                    if (!$recovery->generate()->save()) {
                        Yii::$app->session->setFlash(
                            'error',
                            Yii::t(
                                'mfa',
                                'Sorry, we have failed to generate your recovery codes. Please try again later.'
                            )
                        );
                    }
                    Yii::$app->session->setFlash(
                        'success',
                        Yii::t('mfa', 'Two-factor authentication successfully enabled.')
                    );

                    return empty($back) ? $this->goBack() : $this->deferredRedirect($back);
                } else {

This code seems to be duplicated across your project.

                    Yii::$app->session->setFlash(
                        'error',
                        Yii::t(
                            'mfa',
                            'Sorry, we have failed to enable two-factor authentication.'
                        )
                    );

                    return empty($back) ? $this->goHome() : $this->deferredRedirect($back);
                }
            } else {
                $model->addError(
                    'code',
                    Yii::t('mfa', 'Wrong verification code. Please verify your secret and try again.')
                );
            }
        }

        $qrcode = $this->module->getTotp()->getQRCodeImageAsDataUri($user->getUsername(), $secret);

        return $this->render('enable', compact('model', 'secret', 'qrcode'));
    }

    public function actionDisable($back = null)
    {
        /** @var MfaIdentityInterface $user */
        $user = Yii::$app->user->identity;
        $model = new InputForm();
        $secret = $user->getTotpSecret();

        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            if ($this->module->getTotp()->verifyCode($secret, $model->code)) {
                $this->module->getTotp()->removeSecret();
                $user->setTotpSecret('');
                if ($user->save()) {
                    Yii::$app->session->setFlash(
                        'success',
                        Yii::t('mfa', 'Two-factor authentication successfully disabled.')
                    );
                }

                return empty($back) ? $this->goBack() : $this->deferredRedirect($back);
            } else {
                $model->addError(
                    'code',
                    Yii::t('mfa', 'Wrong verification code. Please verify your secret and try again.')
                );
            }
        }

        return $this->render('disable', compact('model'));
    }

    public function deferredRedirect($url = null)
    {
        return $this->render('redirect', compact('url'));
    }

    public function actionToggle($back = null)
    {
        /** @var MfaIdentityInterface $user */
        $user = Yii::$app->user->identity;

        return empty($user->getTotpSecret()) ? $this->actionEnable($back) : $this->actionDisable($back);
    }

    public function actionCheck()
    {
        /** @var MfaIdentityInterface $user */
        $user = $this->module->getHalfUser();
        $model = new InputForm();
        $secret = $user->getTotpSecret();

        if ($model->load(Yii::$app->request->post()) && $model->validate()) {
            if ($this->module->getTotp()->verifyCode($secret, $model->code)) {
                $this->module->getTotp()->setIsVerified(true);
                Yii::$app->user->login($user);

                return $this->goBack();
            } else {
                $model->addError(
                    'code',
                    Yii::t('mfa', 'Wrong verification code. Please verify your secret and try again.')
                );
            }
        }

        return $this->render(
            'check',
            [
                'model' => $model,
                'issuer' => $this->module->getTotp()->issuer,
                'username' => $user->getUsername(),
            ]
        );
    }

    /**
     * @inheritDoc
     */
    public function goBack($defaultUrl = null)
    {
        $redirectUrl = Yii::$app->params['totpRedirectBackAction.url'];
        if (!empty($redirectUrl)) {
            return $this->redirect($redirectUrl);
        }

        return parent::goBack($defaultUrl);
    }
}