Recovery::verifyCode() - Code Metrics - Inspection of "WIP: add recovery codes" - hiqdev/yii2-mfa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

unknown

created 2020-07-06 09:53 UTC

Recovery::verifyCode() A

↳ Parent: Recovery

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	10
cp	0
rs	9.8333
c	0
b	0
f	0
cc	3
nc	3
nop	0
crap	12

<?php
declare(strict_types=1);

namespace hiqdev\yii2\mfa\base;

use Yii;
use yii\db\ActiveRecord;

class Recovery extends ActiveRecord
{
    public static function tableName()
    {
        return '{{mfa_recovery_codes}}';
    }

    public function rules(): array
    {
        return [
            ['user_id', 'integer'],
            ['user_id', 'required'],
            ['code', 'string'],
            ['code', 'required'],
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function attributeLabels()
    {
        return [
            'code' => Yii::t('mfa', 'Recovery code'),
        ];
    }

    public function setUser(int $id): self {
        $this->user_id = $id;

        return $this;
    }

    public function getUser(): int {
        return $this->user_id;
    }

    public function setCode(string $code): self {
        $this->code = $code;

        return $this;
    }

    public function getCode(): string {
        return $this->code;
    }

    private function setId(int $id): self {

        $this->id = $id;

        return $this;
    }

    private function getId(): int {

        return $this->id;
    }

    public function save($runValidation = true, $attributeNames = null): bool
    {
        $this->code = $this->hashCode($this->code);

        return parent::save($runValidation, $attributeNames);
    }

    public function verifyCode(): bool
    {
        $recoveryCodes = self::findAll(['user_id' => $this->getUser()]);

        foreach ($recoveryCodes ?? [] as $recoveryCode){
            if (Yii::$app->getSecurity()->validatePassword($this->getCode(), $recoveryCode->getCode())){
                $recoveryCode->delete();
                return true;
            }
        }

        return false;
    }

    private function hashCode(string $code): string
    {
        return Yii::$app->security->generatePasswordHash($code);
    }
}

1			<?php
2			declare(strict_types=1);
3
4			namespace hiqdev\yii2\mfa\base;
5
6			use Yii;
7			use yii\db\ActiveRecord;
8
9			class Recovery extends ActiveRecord
10			{
11			public static function tableName()
12			{
13			return '{{mfa_recovery_codes}}';
14			}
15
16			public function rules(): array
17			{
18			return [
19			['user_id', 'integer'],
20			['user_id', 'required'],
21			['code', 'string'],
22			['code', 'required'],
23			];
24			}
25
26			/**
27			* {@inheritdoc}
28			*/
29			public function attributeLabels()
30			{
31			return [
32			'code' => Yii::t('mfa', 'Recovery code'),
33			];
34			}
35
36			public function setUser(int $id): self {
37			$this->user_id = $id;
38
39			return $this;
40			}
41
42			public function getUser(): int {
43			return $this->user_id;
44			}
45
46			public function setCode(string $code): self {
47			$this->code = $code;
48
49			return $this;
50			}
51
52			public function getCode(): string {
53			return $this->code;
54			}
55
56			private function setId(int $id): self {
			0 ignored issues – show Unused Code introduced 2020-07-05 21:57 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
57			$this->id = $id;
58
59			return $this;
60			}
61
62			private function getId(): int {
			0 ignored issues – show Unused Code introduced 2020-07-05 21:57 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
63			return $this->id;
64			}
65
66			public function save($runValidation = true, $attributeNames = null): bool
67			{
68			$this->code = $this->hashCode($this->code);
69
70			return parent::save($runValidation, $attributeNames);
71			}
72
73			public function verifyCode(): bool
74			{
75			$recoveryCodes = self::findAll(['user_id' => $this->getUser()]);
76
77			foreach ($recoveryCodes ?? [] as $recoveryCode){
78			if (Yii::$app->getSecurity()->validatePassword($this->getCode(), $recoveryCode->getCode())){
79			$recoveryCode->delete();
80			return true;
81			}
82			}
83
84			return false;
85			}
86
87			private function hashCode(string $code): string
88			{
89			return Yii::$app->security->generatePasswordHash($code);
90			}
91			}

hiqdev / yii2-mfa

Pull Request — master (#13)

Recovery::verifyCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like