hiqdev\yii2\merchant\controllers\PayController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	154
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	1

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getMerchantModule()	0	4	1
A	beforeAction()	0	8	2
A	actionCancel()	0	6	2
A	actionReturn()	0	8	1
A	actionCheckReturn()	0	14	3
A	actionNotify()	0	7	2
A	checkNotify()	0	6	1
A	actionDeposit()	0	11	4
A	renderDeposit()	0	10	2
B	actionRequest()	0	24	4

<?php
/**
 * Yii2 extension for payment processing with Omnipay, Payum and more later.
 *
 * @link      https://github.com/hiqdev/yii2-merchant
 * @package   yii2-merchant
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\yii2\merchant\controllers;

use hiqdev\yii2\merchant\Module;
use Yii;
use yii\base\InvalidCallException;
use yii\base\UserException;
use yii\helpers\Json;
use yii\web\BadRequestHttpException;
use yii\web\Response;

class PayController extends \yii\web\Controller
{
    /**
     * @return Module|\yii\base\Module
     */
    public function getMerchantModule()
    {
        return $this->module;
    }

    /**
     * Disable CSRF validation for POST requests we receive from outside
     * {@inheritdoc}
     */
    public function beforeAction($action)
    {
        if (in_array($this->action->id, ['notify', 'return', 'cancel'], true)) {
            Yii::$app->controller->enableCsrfValidation = false;
        }

        return parent::beforeAction($action);
    }

    /**
     * @return Response
     */
    public function actionCancel()
    {
        Yii::$app->session->addFlash('error', Yii::t('merchant', 'Payment failed or cancelled'));

        return $this->redirect($this->getMerchantModule()->previousUrl() ?: ['deposit']);
    }

    /**
     * @return string
     */
    public function actionReturn()
    {
        $this->checkNotify();

        return $this->render('return', [
            'transactionId' => Yii::$app->request->get('transactionId'),
        ]);
    }

    /**
     * @param string $transactionId
     * @throws BadRequestHttpException
     * @return array
     */
    public function actionCheckReturn($transactionId)
    {
        Yii::$app->response->format = Response::FORMAT_JSON;
        $data = $this->getMerchantModule()->readHistory($transactionId);

        if ($data['username'] !== $this->getMerchantModule()->username) {
            throw new BadRequestHttpException('Access denied', 403);
        }

        return [
            'status' => $data['_isCompleted'],
            'url'    => $data['_isCompleted'] ? $data['finishUrl'] : $data['cancelUrl'],
        ];
    }

    /**
     * Action is designed to get the system notification from payment system,
     * process it and report success or error for the payment system.
     * @return null|string
     */
    public function actionNotify()
    {
        $result = $this->checkNotify();
        Yii::$app->response->format = Response::FORMAT_RAW;

        return $result['_isCompleted'] ? 'OK' : $result['_error'];
    }

    /**
     * Check notifications.
     * TODO: implement actual request check and proper handling.
     * @return array
     */
    public function checkNotify()

checkNotify uses the super-global variable $_REQUEST which is generally not recommended.

    {
        $result = $_REQUEST;

        return $this->completeHistory($result);

The method completeHistory does not exist on object<hiqdev\yii2\merchant\controllers\PayController>? Since you implemented __call, maybe consider adding a @method annotation.

    }

    public function actionDeposit()
    {
        $model   = Yii::createObject($this->getMerchantModule()->depositClass);
        $request = Yii::$app->request;
        $availableMerchants = $this->getMerchantModule()->getCollection()->getItems();
        if ($model->load($request->isPost ? $request->post() : $request->get()) && $model->validate()) {
            return $this->renderDeposit($model->getAttributes());
        }

        return $this->render('deposit-form', compact('model', 'availableMerchants'));
    }

    /**
     * Renders depositing buttons for given request data.
     *
     * @param array $data request data:
     *  - `sum` - the amount of payment without fees
     *  - `currency` - the currency of transaction
     *  - `finishPage/Url` - page or URL to redirect user after the payment
     *  - `returnPage/Url` - page or URL to return user from payment system on success
     *  - `cancelPage/Url` - page or URL to return user from payment system on fail
     *  - `notifyPage/Url` - page or URL used by payment system to notify us on successful payment
     * @return \yii\web\Response
     */
    public function renderDeposit(array $data)
    {
        $merchants = $this->getMerchantModule()->getCollection($data)->getItems();
        $requests = [];
        foreach ($merchants as $id => $merchant) {
            $requests[$id] = $merchant->request('purchase', $this->getMerchantModule()->prepareRequestData($id, $data));
        }

        return $this->render('deposit', compact('requests'));
    }

    /**
     * Performs purchase request.
     * @void
     */
    public function actionRequest()
    {
        $merchant   = Yii::$app->request->post('merchant');
        if (empty($merchant)) {
            throw new BadRequestHttpException('Merchant is missing');
        }

        $data       = Json::decode(Yii::$app->request->post('data', '{}'));
        $merchant   = $this->getMerchantModule()->getMerchant($merchant, $data);
        $request    = $merchant->request('purchase', $data);

        $this->getMerchantModule()->writeHistory(array_merge($data, ['username' => $this->getMerchantModule()->username]));

        $response   = $request->send();

        if ($response->isSuccessful()) {
            throw new InvalidCallException('Instant payment is not implemented yet');
//            $merchant->registerMoney($response);

75% of this comment could be valid code. Did you maybe forget this after debugging?

        } elseif ($response->isRedirect()) {
            $response->redirect();
        } else {
            throw new UserException('Merchant request failed');
        }
    }
}