hiqdev\higrid\representations\RepresentationCollection

Complexity

Total Complexity

11

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	fillRepresentations()	0	4	1
A	getAll()	0	16	4
A	getByName()	0	8	2
A	getDefault()	0	8	2
A	exists()	0	4	1

<?php

namespace hiqdev\higrid\representations;

use Yii;
use yii\base\Exception;
use yii\base\InvalidConfigException;

/**
 * Class RepresentationCollection represents a collection of [[Representation]] objects
 * and provides API to access them.
 *
 * @author Dmytro Naumenko <d.naumenko.a@gmail.com>
 */
class RepresentationCollection implements RepresentationCollectionInterface
{
    /**
     * RepresentationCollection constructor.
     */
    public function __construct()
    {
        $this->fillRepresentations();
    }

    /**
     * @var array
     */
    protected $representations = [];

    /**
     * @void
     */
    protected function fillRepresentations()
    {
        $this->representations = [];
    }

    /**
     * {@inheritdoc}
     */
    public function getAll()
    {
        foreach ($this->representations as $name => $representation) {
            if (!is_object($representation)) {
                $representation = $this->representations[$name] = Yii::createObject(array_merge([
                    'class' => Representation::class
                ], $representation));
            }

            if (!$representation instanceof RepresentationInterface) {
                throw new InvalidConfigException('Representation "' . $name .'" must be instance of RepresentationInterface');
            }
        }

        return $this->representations;
    }

    /**
     * {@inheritdoc}
     */
    public function getByName($name)
    {
        if (!$this->exists($name)) {
            $this->getDefault();
        }

        return $this->getAll()[$name];
    }

    /**
     * {@inheritdoc}
     */
    public function getDefault()
    {
        if (count($this->getAll()) === 0) {
            throw new InvalidConfigException('Default can not be applied because collection is empty.');
        }

        return reset($this->getAll());

$this->getAll() cannot be passed to reset() as the parameter $array expects a reference.

The expression reset($this->getAll()); of type hiqdev\higrid\representations\RepresentationInterface|false adds false to the return on line 79 which is incompatible with the return type declared by the interface hiqdev\higrid\representations\RepresentationCollectionInterface::getDefault of type hiqdev\higrid\representations\RepresentationInterface. It seems like you forgot to handle an error condition.

    }

    /**
     * {@inheritdoc}
     */
    public function exists($name)
    {
        return isset($this->getAll()[$name]);
    }
}