Request::send() - Code Metrics - Inspection of "added phpunit 5 <-> 6 compatibility dirty hack" - hiqdev/yii2-hiart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f4889a...d7a000 )

by Andrii

created 2017-03-30 10:10 UTC

Request::send() A

↳ Parent: Request

Complexity

Conditions	3
Paths	17

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	0
cts	14
cp	0
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	15
nc	17
nop	1
crap	12

<?php
/**
 * ActiveRecord for API
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\curl;

use hiqdev\hiart\AbstractRequest;
use hiqdev\hiart\RequestErrorException;
use yii\helpers\ArrayHelper;

/**
 * Class Request represents request using cURL library.
 */
class Request extends AbstractRequest
{
    protected $responseClass = Response::class;

    /**
     * @var array default cURL options
     */
    public $defaultOptions = [
        CURLOPT_SSL_VERIFYPEER => false,
        CURLOPT_RETURNTRANSFER => true,
        CURLOPT_HEADER => true,
    ];

    /**
     * @param array $options
     * @throws RequestErrorException
     * @return array|mixed
     */
    public function send($options = [])
    {
        try {
            $this->build();

            $curl = curl_init($this->getFullUri());
            curl_setopt_array($curl, $this->prepareCurlOptions($options));
            $response = curl_exec($curl);
            $info = curl_getinfo($curl);
            $error = curl_error($curl);
            $errorCode = curl_errno($curl);
            curl_close($curl);
        } catch (RequestErrorException $e) {
            throw $e;
        } catch (\Exception $e) {
            throw new RequestErrorException($e->getMessage(), $this, $e->getCode(), $e);
        }

        return new $this->responseClass($this, $response, $info, $error, $errorCode);
    }

    /**
     * @param array $options
     * @throws RequestErrorException
     * @return array
     */
    protected function prepareCurlOptions($options)
    {
        $requestOptions = $this->buildMethodOptions();
        $requestOptions[CURLOPT_HTTPHEADER] = $this->buildHeaderLines();

        if ($this->getVersion() === '1.1') {
            $requestOptions[CURLOPT_HTTP_VERSION] = CURL_HTTP_VERSION_1_1;
        } elseif ($this->getVersion() === '1.0') {
            $requestOptions[CURLOPT_HTTP_VERSION] = CURL_HTTP_VERSION_1_0;
        } else {
            throw new RequestErrorException('Request version "' . $this->getVersion() . '" is not support by cURL', $this);
        }

        return ArrayHelper::merge($this->defaultOptions, $this->getDb()->config, $requestOptions, $options);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    /**
     * @return array
     */
    protected function buildMethodOptions()
    {
        $options = [];

        if ($this->getMethod() === 'GET') {
            return $options;
        }

        if (!empty($this->getBody())) {
            $options[CURLOPT_POSTFIELDS] = $this->getBody();
        }

        if ($this->getMethod() === 'POST') {
            $options[CURLOPT_POST] = true;
        } else {
            $options[CURLOPT_CUSTOMREQUEST] = $this->getMethod();
        }

        return $options;
    }

    /**
     * @return array
     */
    protected function buildHeaderLines()

    {
        $result = [];

        foreach ($this->getHeaders() as $name => $values) {
            $name = str_replace(' ', '-', ucwords(str_replace('-', ' ', $name)));
            if (is_string($values)) {
                $values = [$values];
            }
            foreach ($values as $value) {
                $result[] = "$name: $value";
            }
        }

        return $result;
    }

    public static function isSupported()
    {
        return function_exists('curl_version');
    }
}


1		<?php
2		/**
3		* ActiveRecord for API
4		*
5		* @link https://github.com/hiqdev/yii2-hiart
6		* @package yii2-hiart
7		* @license BSD-3-Clause
8		* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9		*/
10
11		namespace hiqdev\hiart\curl;
12
13		use hiqdev\hiart\AbstractRequest;
14		use hiqdev\hiart\RequestErrorException;
15		use yii\helpers\ArrayHelper;
16
17		/**
18		* Class Request represents request using cURL library.
19		*/
20		class Request extends AbstractRequest
21		{
22		protected $responseClass = Response::class;
23
24		/**
25		* @var array default cURL options
26		*/
27		public $defaultOptions = [
28		CURLOPT_SSL_VERIFYPEER => false,
29		CURLOPT_RETURNTRANSFER => true,
30		CURLOPT_HEADER => true,
31		];
32
33		/**
34		* @param array $options
35		* @throws RequestErrorException
36		* @return array\|mixed
37		*/
38		public function send($options = [])
39		{
40		try {
41		$this->build();
42
43		$curl = curl_init($this->getFullUri());
44		curl_setopt_array($curl, $this->prepareCurlOptions($options));
45		$response = curl_exec($curl);
46		$info = curl_getinfo($curl);
47		$error = curl_error($curl);
48		$errorCode = curl_errno($curl);
49		curl_close($curl);
50		} catch (RequestErrorException $e) {
51		throw $e;
52		} catch (\Exception $e) {
53		throw new RequestErrorException($e->getMessage(), $this, $e->getCode(), $e);
54		}
55
56		return new $this->responseClass($this, $response, $info, $error, $errorCode);
57		}
58
59		/**
60		* @param array $options
61		* @throws RequestErrorException
62		* @return array
63		*/
64		protected function prepareCurlOptions($options)
65		{
66		$requestOptions = $this->buildMethodOptions();
67		$requestOptions[CURLOPT_HTTPHEADER] = $this->buildHeaderLines();
68
69		if ($this->getVersion() === '1.1') {
70		$requestOptions[CURLOPT_HTTP_VERSION] = CURL_HTTP_VERSION_1_1;
71		} elseif ($this->getVersion() === '1.0') {
72		$requestOptions[CURLOPT_HTTP_VERSION] = CURL_HTTP_VERSION_1_0;
73		} else {
74		throw new RequestErrorException('Request version "' . $this->getVersion() . '" is not support by cURL', $this);
75		}
76
77		return ArrayHelper::merge($this->defaultOptions, $this->getDb()->config, $requestOptions, $options);
		0 ignored issues – show Bug introduced 2017-01-26 17:33 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `hiqdev\hiart\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
78		}
79
80		/**
81		* @return array
82		*/
83		protected function buildMethodOptions()
84		{
85		$options = [];
86
87		if ($this->getMethod() === 'GET') {
88		return $options;
89		}
90
91		if (!empty($this->getBody())) {
92		$options[CURLOPT_POSTFIELDS] = $this->getBody();
93		}
94
95		if ($this->getMethod() === 'POST') {
96		$options[CURLOPT_POST] = true;
97		} else {
98		$options[CURLOPT_CUSTOMREQUEST] = $this->getMethod();
99		}
100
101		return $options;
102		}
103
104		/**
105		* @return array
106		*/
107	View Code Duplication	protected function buildHeaderLines()
		0 ignored issues – show Duplication introduced 2017-01-26 17:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108		{
109		$result = [];
110
111		foreach ($this->getHeaders() as $name => $values) {
112		$name = str_replace(' ', '-', ucwords(str_replace('-', ' ', $name)));
113		if (is_string($values)) {
114		$values = [$values];
115		}
116		foreach ($values as $value) {
117		$result[] = "$name: $value";
118		}
119		}
120
121		return $result;
122		}
123
124		public static function isSupported()
125		{
126		return function_exists('curl_version');
127		}
128		}
129

hiqdev / yii2-hiart

Push — master ( f4889a...d7a000 )

Request::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like