Request::send() - Code Metrics - Inspection of "minor" - hiqdev/yii2-hiart - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c8064d...729f46 )

by Dmitry

created 2017-01-26 17:30 UTC

Request::send() A

↳ Parent: Request

Complexity

Conditions	2
Paths	6

Size

Total Lines	16
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2.032

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	8
cts	10
cp	0.8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	11
nc	6
nop	1
crap	2.032

<?php
/**
 * Tools to use API as ActiveRecord for Yii2
 *
 * @link      https://github.com/hiqdev/yii2-hiart
 * @package   yii2-hiart
 * @license   BSD-3-Clause
 * @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
 */

namespace hiqdev\hiart\stream;

use hiqdev\hiart\AbstractRequest;
use hiqdev\hiart\RequestErrorException;
use yii\helpers\ArrayHelper;
use yii\helpers\Inflector;

/**
 * PHP stream request implementation.
 *
 * @author Andrii Vasyliev <[email protected]>
 */
class Request extends AbstractRequest
{
    protected $responseClass = Response::class;

    public $defaultOptions = [
        'http' => [
            'ignore_errors' => true,
        ],
        'ssl' => [
            'verify_peer' => false,
        ],
    ];

    /**
     * @param array $options
     * @throws RequestErrorException
     * @return mixed
     */
    public function send($options = [])
    {
        try {
            $this->build();
            $context = stream_context_create($this->prepareContextOptions($options));
            $stream = fopen($this->getFullUri(), 'rb', false, $context);
            $responseContent = stream_get_contents($stream);
            // see http://php.net/manual/en/reserved.variables.httpresponseheader.php
            $responseHeaders = $http_response_header;
            fclose($stream);
        } catch (\Exception $e) {
            throw new RequestErrorException($e->getMessage(), $this, $e->getCode(), $e);
        }

        return new $this->responseClass($this, $responseContent, $responseHeaders);
    }

    protected function prepareContextOptions($options)
    {
        $requestOptions = [
            'http' => [
                'protocol_version' => $this->version,
                'method' => $this->method,
                'header' => static::composeHeaderLines($this->headers),
            ],
        ];

        if (isset($this->body)) {
            $requestOptions['http']['content'] = $this->body;
        }

        $dbOptions = $this->convertContextOptions($this->getDb()->config);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $sendOptions = $this->convertContextOptions($options);

        return ArrayHelper::merge($this->defaultOptions, $dbOptions, $requestOptions, $sendOptions);
    }

    /**
     * Composes stream context options from raw options.
     * @param array $options raw options
     * @return array stream context options
     */
    protected function convertContextOptions(array $options)
    {
        $contextOptions = [];
        foreach ($options as $key => $value) {
            $section = 'http';
            if (strpos($key, 'ssl') === 0) {
                $section = 'ssl';
                $key = substr($key, 3);
            }
            $key = Inflector::underscore($key);
            $contextOptions[$section][$key] = $value;
        }

        return $contextOptions;
    }

    public static function composeHeaderLines($headers)

    {
        $result = [];
        foreach ($headers as $name => $values) {
            $name = str_replace(' ', '-', ucwords(str_replace('-', ' ', $name)));
            if (is_string($values)) {
                $values = [$values];
            }
            foreach ($values as $value) {
                $result[] = "$name: $value";
            }
        }

        return $result;
    }
}


1			<?php
2			/**
3			* Tools to use API as ActiveRecord for Yii2
4			*
5			* @link https://github.com/hiqdev/yii2-hiart
6			* @package yii2-hiart
7			* @license BSD-3-Clause
8			* @copyright Copyright (c) 2015-2017, HiQDev (http://hiqdev.com/)
9			*/
10
11			namespace hiqdev\hiart\stream;
12
13			use hiqdev\hiart\AbstractRequest;
14			use hiqdev\hiart\RequestErrorException;
15			use yii\helpers\ArrayHelper;
16			use yii\helpers\Inflector;
17
18			/**
19			* PHP stream request implementation.
20			*
21			* @author Andrii Vasyliev <[email protected]>
22			*/
23			class Request extends AbstractRequest
24			{
25			protected $responseClass = Response::class;
26
27			public $defaultOptions = [
28			'http' => [
29			'ignore_errors' => true,
30			],
31			'ssl' => [
32			'verify_peer' => false,
33			],
34			];
35
36			/**
37			* @param array $options
38			* @throws RequestErrorException
39			* @return mixed
40			*/
41	2		public function send($options = [])
42			{
43			try {
44	2		$this->build();
45	2		$context = stream_context_create($this->prepareContextOptions($options));
46	2		$stream = fopen($this->getFullUri(), 'rb', false, $context);
47	2		$responseContent = stream_get_contents($stream);
48			// see http://php.net/manual/en/reserved.variables.httpresponseheader.php
49	2		$responseHeaders = $http_response_header;
50	2		fclose($stream);
51			} catch (\Exception $e) {
52			throw new RequestErrorException($e->getMessage(), $this, $e->getCode(), $e);
53			}
54
55	2		return new $this->responseClass($this, $responseContent, $responseHeaders);
56			}
57
58	2		protected function prepareContextOptions($options)
59			{
60			$requestOptions = [
61			'http' => [
62	2		'protocol_version' => $this->version,
63	2		'method' => $this->method,
64	2		'header' => static::composeHeaderLines($this->headers),
65			],
66			];
67
68	2		if (isset($this->body)) {
69			$requestOptions['http']['content'] = $this->body;
70			}
71
72	2		$dbOptions = $this->convertContextOptions($this->getDb()->config);
			0 ignored issues – show Bug introduced 2017-01-25 17:14 UTC by Report Bug Copy Issue Report Accessing `config` on the interface `hiqdev\hiart\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73	2		$sendOptions = $this->convertContextOptions($options);
74
75	2		return ArrayHelper::merge($this->defaultOptions, $dbOptions, $requestOptions, $sendOptions);
76			}
77
78			/**
79			* Composes stream context options from raw options.
80			* @param array $options raw options
81			* @return array stream context options
82			*/
83	2		protected function convertContextOptions(array $options)
84			{
85	2		$contextOptions = [];
86	2		foreach ($options as $key => $value) {
87			$section = 'http';
88			if (strpos($key, 'ssl') === 0) {
89			$section = 'ssl';
90			$key = substr($key, 3);
91			}
92			$key = Inflector::underscore($key);
93			$contextOptions[$section][$key] = $value;
94			}
95
96	2		return $contextOptions;
97			}
98
99	2	View Code Duplication	public static function composeHeaderLines($headers)
			0 ignored issues – show Duplication introduced 2017-01-26 17:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100			{
101	2		$result = [];
102	2		foreach ($headers as $name => $values) {
103	2		$name = str_replace(' ', '-', ucwords(str_replace('-', ' ', $name)));
104	2		if (is_string($values)) {
105	2		$values = [$values];
106			}
107	2		foreach ($values as $value) {
108	2		$result[] = "$name: $value";
109			}
110			}
111
112	2		return $result;
113			}
114			}
115

hiqdev / yii2-hiart

Push — master ( c8064d...729f46 )

Request::send() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like